Repository navigation
Commit a3e2a89
committed
fix(review): PR #1041 pre-merge review findings
Bot review on the v0.9.3 release PR caught three correctness gaps and a
CI-blocking branding-audit trip. All fixed here so the release stays clean:
- **`cliVersion` default in `reviewPullRequest`.** Only the CLI command
forwarded `Installation.VERSION`; the agent-invoked `dbt_pr_review` tool
wrapper never did, so tool-path verdicts silently dropped
`engine.cliVersion` and defeated the audit-trail promise the field was
added for. Default the option to `Installation.VERSION` inside
`reviewPullRequest` so both entry points populate it. (cubic P2 conf 9)
- **`staleManifest` deletion false-negative.** `detectStaleManifest`
previously took `changedPaths: string[]` and tried to `stat` each — a
deletion of a manifest-affecting model reported CLEAN because the file
no longer exists on disk. The signed envelope then falsely certified a
verdict against ghost models. Pass the full `ChangedFile[]` through
instead and treat `deleted` / `renamed` manifest-affecting entries as
unconditionally stale (they can't be stat'd but the manifest still
references them, so the metadata is by definition out of date). Rename
covers both sides so a rename-away and a rename-to both trip.
(cubic P2 conf 8)
- **Docs boundary-matching wording + non-match example.** The
`riskTierPathTokens` doc claimed "case-insensitive substrings" but
`compilePathTokenResolver` actually anchors tokens at path/word/digit
boundaries — `cost` fires on `mrt_cost_daily.sql` but not on
`broadcaster.sql`. Correct the wording and add the non-match example
so users don't configure tokens that don't match their intent.
(cubic P2 conf 5 + coderabbit)
- **Branding-audit trip in `script/release-preflight.ts:609`.** The
operational instruction telling the operator how to add the upstream
remote (`git remote add upstream https://github.com/anomalyco/opencode.git`)
legitimately names the upstream URL. The CI branding audit doesn't know
operational text from branding drift; wrap the block in `altimate_change`
markers so the audit skips it.1 parent afcca83 commit a3e2a89
3 files changed
Lines changed: 56 additions & 16 deletions
File tree
- docs/docs/usage
- packages/opencode/src/altimate/review
- script
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
251 | 251 | | |
252 | 252 | | |
253 | 253 | | |
254 | | - | |
255 | | - | |
256 | | - | |
257 | | - | |
258 | | - | |
259 | | - | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
260 | 264 | | |
261 | 265 | | |
262 | 266 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
3 | 4 | | |
4 | 5 | | |
5 | 6 | | |
| |||
152 | 153 | | |
153 | 154 | | |
154 | 155 | | |
155 | | - | |
156 | | - | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
157 | 164 | | |
158 | 165 | | |
159 | | - | |
160 | | - | |
161 | | - | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
162 | 186 | | |
163 | 187 | | |
164 | 188 | | |
165 | | - | |
| 189 | + | |
166 | 190 | | |
167 | 191 | | |
168 | 192 | | |
169 | 193 | | |
170 | | - | |
| 194 | + | |
171 | 195 | | |
172 | 196 | | |
173 | 197 | | |
174 | 198 | | |
175 | 199 | | |
176 | | - | |
| 200 | + | |
177 | 201 | | |
178 | 202 | | |
179 | 203 | | |
| |||
256 | 280 | | |
257 | 281 | | |
258 | 282 | | |
259 | | - | |
| 283 | + | |
260 | 284 | | |
261 | 285 | | |
262 | 286 | | |
| |||
317 | 341 | | |
318 | 342 | | |
319 | 343 | | |
320 | | - | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
321 | 350 | | |
322 | 351 | | |
323 | 352 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
603 | 603 | | |
604 | 604 | | |
605 | 605 | | |
| 606 | + | |
| 607 | + | |
| 608 | + | |
| 609 | + | |
| 610 | + | |
| 611 | + | |
606 | 612 | | |
607 | 613 | | |
608 | 614 | | |
609 | 615 | | |
610 | 616 | | |
| 617 | + | |
611 | 618 | | |
612 | 619 | | |
613 | 620 | | |
| |||
0 commit comments