Skip to content

Commit a36e9a8

Browse files
mhallidaclaude
andcommitted
fix: altimate_core_migration reads correct field names from MigrationResult
MigrationResult from Rust uses {findings, safe, overall_risk} not {risks}. MigrationFinding uses {risk, operation, message, mitigation} not {severity, type, recommendation}. The tool was checking data.risks which was always undefined, so it always reported "safe." Now correctly reads findings and maps MigrationFinding fields. Fixes TICKET-013 in #422. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
1 parent 570ea09 commit a36e9a8

1 file changed

Lines changed: 23 additions & 7 deletions

File tree

‎packages/opencode/src/altimate/tools/altimate-core-migration.ts‎

Lines changed: 23 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,12 @@ export const AltimateCoreMigrationTool = Tool.define("altimate_core_migration",
1818
dialect: args.dialect ?? "",
1919
})
2020
const data = result.data as Record<string, any>
21-
const riskCount = data.risks?.length ?? 0
21+
// MigrationResult uses "findings" not "risks"
22+
const findings = data.findings ?? data.risks ?? []
23+
const riskCount = findings.length
24+
const isSafe = data.safe ?? (riskCount === 0)
2225
return {
23-
title: `Migration: ${riskCount === 0 ? "SAFE" : `${riskCount} risk(s)`}`,
26+
title: `Migration: ${isSafe ? "SAFE" : `${riskCount} risk(s)`}`,
2427
metadata: { success: result.success, risk_count: riskCount },
2528
output: formatMigration(data),
2629
}
@@ -33,11 +36,24 @@ export const AltimateCoreMigrationTool = Tool.define("altimate_core_migration",
3336

3437
function formatMigration(data: Record<string, any>): string {
3538
if (data.error) return `Error: ${data.error}`
36-
if (!data.risks?.length) return "Migration appears safe. No risks detected."
37-
const lines = ["Migration risks:\n"]
38-
for (const r of data.risks) {
39-
lines.push(` [${r.severity ?? "warning"}] ${r.type}: ${r.message}`)
40-
if (r.recommendation) lines.push(` Recommendation: ${r.recommendation}`)
39+
// MigrationResult uses "findings" with MigrationFinding shape:
40+
// { risk: MigrationRisk, operation: string, message: string, mitigation?: string, rollback_sql?: string }
41+
const findings = data.findings ?? data.risks ?? []
42+
if (!findings.length) return "Migration appears safe. No risks detected."
43+
44+
const lines: string[] = []
45+
if (data.overall_risk) lines.push(`Overall risk: ${data.overall_risk}`)
46+
lines.push(`\nMigration risks (${findings.length}):\n`)
47+
for (const r of findings) {
48+
const severity = r.risk ?? r.severity ?? "warning"
49+
const operation = r.operation ?? r.type ?? "change"
50+
lines.push(` [${severity.toUpperCase()}] ${operation}: ${r.message}`)
51+
if (r.mitigation ?? r.recommendation) {
52+
lines.push(` Mitigation: ${r.mitigation ?? r.recommendation}`)
53+
}
54+
if (r.rollback_sql) {
55+
lines.push(` Rollback: ${r.rollback_sql}`)
56+
}
4157
}
4258
return lines.join("\n")
4359
}

0 commit comments

Comments
 (0)