Repository navigation
Commit 9a48e8a
committed
fix(harness): exempt UID:GID explicitly, not by absence of letters
Corrects a credential leak introduced by the previous commit's redaction
change, caught on re-review.
Exempting a colon-shaped --user value whenever it had no alphabetic character
before the colon was wrong in the leaking direction: `tool --user 1234:secret`
is a numeric username with a real password, and it stopped being redacted.
Verified against the built predicate before and after.
The exemption is now exactly what it was meant to be — an all-numeric UID:GID
pair (`^\\d+:\\d+$`). `docker run --user 1000:1000` is still preserved as a task
detail; `1234:secret` and `alice:secret` both redact.
Also corrects the comment above the curl-context fix, which overclaimed. That
fix redacts the value ATTACHED to -u; a password passed as a separate
following token is not covered, is not specific to the .exe spelling, and the
obvious widening would eat the URL operand in the already-tested
`curl -u alice https://example.com`. Left open for a human call.1 parent 0263449 commit 9a48e8a
2 files changed
Lines changed: 21 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
610 | 610 | | |
611 | 611 | | |
612 | 612 | | |
613 | | - | |
| 613 | + | |
| 614 | + | |
| 615 | + | |
| 616 | + | |
614 | 617 | | |
615 | 618 | | |
616 | 619 | | |
617 | | - | |
618 | | - | |
619 | | - | |
620 | | - | |
621 | | - | |
| 620 | + | |
| 621 | + | |
| 622 | + | |
| 623 | + | |
| 624 | + | |
| 625 | + | |
| 626 | + | |
| 627 | + | |
| 628 | + | |
| 629 | + | |
622 | 630 | | |
623 | 631 | | |
624 | 632 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
434 | 434 | | |
435 | 435 | | |
436 | 436 | | |
| 437 | + | |
| 438 | + | |
| 439 | + | |
| 440 | + | |
| 441 | + | |
| 442 | + | |
| 443 | + | |
437 | 444 | | |
438 | 445 | | |
439 | 446 | | |
| |||
0 commit comments