You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 960229d
Browse filesBrowse the repository at this point in the historyBrowse files
Abstention and fail-closed hardening:
- `check --checks pii`: engine `parse_error` abstentions now produce an
error finding ("PII analysis skipped: …") instead of an empty pass —
`--fail-on` no longer PASSes files whose PII analysis never ran.
- Composite `altimate_core.check`: a thrown `checkQueryPii` now marks the
PII section as an abstention (`parse_error`) instead of leaving `{}`,
which rendered a false-clean "No PII detected"; `formatCheckTitle`
reports "PII check skipped" instead of PASS for abstained-but-clean runs.
- `schema.detect_pii`: per-column classify failures are counted and flip
`success` to false (fail closed) instead of being silently swallowed;
`piiColumnsFromReport` now throws on malformed reports (missing/non-array
`columns`) rather than yielding zero findings.
- `altimate_core_query_pii` tool: abstentions set `metadata.success: false`
so telemetry's soft-failure classification records them.
Correctness:
- `check --checks grade`: per-file grades (`results.grade.grades`) — the
shared `gradeValue`/`gradeScore` raced across concurrent batch promises,
keeping whichever file finished last; flat `grade`/`score` retained for
single-file runs only.
Module shape / dedup:
- `engine-coerce.ts` gets the AGENTS.md-prescribed `EngineCoerce`
self-reexport; all consumers import the namespace projection.
- `review/runner.ts` drops its local `bandConfidence` for the shared one;
shared version now bands missing/non-numeric confidence as "medium"
(matching the runner's previous behavior).
Tests: CLI PII-abstention and multi-file grade regression tests;
"PII check skipped" title test; strict malformed-PiiReport assertions;
classify-pii e2e asserts a positive `pii_count` lower bound; DuckDB e2e
closes its connector and restores the telemetry env var on teardown.
Co-Authored-By: Claude Fable 5 <[email protected]>
0 commit comments