Repository navigation
Commit 8e6d52f
fix(onboarding): close an unterminated marker block, de-order the launch_id test
The three test failures on this PR predate the last two commits — the same three
were red on `a949fdc`.
- `telemetry/index.ts` had 35 `altimate_change start` against 34 ends: the
"serialize flushes" block opened inside `flush()` and never closed. That is
what both `altimate_change marker integrity` and `bridge merge: ... marker
integrity` were reporting.
- The launch-correlation test needs the REAL `Telemetry.init()`, since the launch
id is minted there and nowhere else, but every other describe in that file
spies `init` to a no-op to keep the funnel tests off the filesystem. The test
was relying on a sibling's `afterEach` to have undone that spy, so its result
depended on suite ordering: green when the file ran alone, red in the shared
process. It now restores explicitly — before installing its own fetch spy, not
after, which would remove it — clears `initPromise` via `shutdown()`, and
asserts `isEnabled()` so any future sabotage fails with a cause instead of a
mysteriously empty batch.
Verified with the full CI command: 11,833 tests across 574 files, 0 fail —
matching CI's own counts, so the shared-process condition the failure depends on
was actually reproduced. The subprocess pass was already green on CI and touches
none of this.
Co-Authored-By: Claude Opus 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_018SLUQF3xgZHsGZHSjxe7vb1 parent b66bbe9 commit 8e6d52f
2 files changed
Lines changed: 15 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1730 | 1730 | | |
1731 | 1731 | | |
1732 | 1732 | | |
| 1733 | + | |
1733 | 1734 | | |
1734 | 1735 | | |
1735 | 1736 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
354 | 354 | | |
355 | 355 | | |
356 | 356 | | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
357 | 362 | | |
358 | 363 | | |
359 | 364 | | |
| |||
376 | 381 | | |
377 | 382 | | |
378 | 383 | | |
| 384 | + | |
| 385 | + | |
| 386 | + | |
| 387 | + | |
| 388 | + | |
379 | 389 | | |
| 390 | + | |
| 391 | + | |
| 392 | + | |
| 393 | + | |
380 | 394 | | |
381 | 395 | | |
382 | 396 | | |
| |||
0 commit comments