You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 8da3abe
Browse filesBrowse the repository at this point in the historyBrowse files
fix(workspace): mirror state on globalThis, bounded flush on signals, no sync promise for a stale link
Codex review of #1344 (gpt-5.6-sol).
- `mirrorsInFlight` and the per-block queues were plain module state, while
this module is reached through two specifiers (`@/…` from `MemoryStore`,
relative from the `run` exit path) — the situation skill-sync already
anchors its tables on `globalThis` for. Same anchor here, so the set the
flush reads is the set the writer filled whatever the runtime does with
module records; test mirrors through one specifier and flushes through the
other
- SIGINT/SIGTERM exited at once, killing an upload of a block saved that
turn. The signal handlers now hold for pending mirrors up to 2s (a second
signal is not delayed) before exiting with the same code
- The team-memory line is not rendered on a stale outcome: "last known … may
since have changed" followed by "syncs to the workspace" contradicted itself
- Test: the production enablement check (the same `memoryStatus` the write
path and backfill run) fills the memo the line reads — skipping the cache
write fails it (checked by mutation); a confirmed-on memo on a stale link
shows no line
Not changed: `serve`, the TUI and ACP exits still do not drain mirrors
(pre-existing, separate entry points); the first turn of a cold one-shot
`run` can miss the line while the enablement request is in flight — the
`altimate_memory_write` description carries the same guidance for that turn.
Co-Authored-By: Claude Opus 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_012Q51zFUmPg1WwtS5CrGJE6
0 commit comments