Repository navigation
Commit 87562bf
fix: address coderabbit + cubic review comments
- trace.ts:172-173 (coderabbit): switch pagination fallbacks from || to ??
so an explicit --offset 0 / --limit 0 reaches listTracesPaginated() for
clamping, rather than being swallowed as falsy and replaced with
defaults. The API already clamps limit<1 to 1, so --limit 0 now
routes through that clamp path correctly.
- tracing.test.ts:746 (cubic): create a fresh Trace instance per
iteration inside seedTraces() rather than reusing a single tracer.
Reusing a tracer across startTrace/endTrace cycles accumulates
spans in memory across iterations. Matches the pattern used by
the maxFiles test.1 parent fb93606 commit 87562bf
2 files changed
Lines changed: 12 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
168 | 168 | | |
169 | 169 | | |
170 | 170 | | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
171 | 176 | | |
172 | | - | |
173 | | - | |
| 177 | + | |
| 178 | + | |
174 | 179 | | |
175 | 180 | | |
176 | 181 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
742 | 742 | | |
743 | 743 | | |
744 | 744 | | |
745 | | - | |
| 745 | + | |
| 746 | + | |
| 747 | + | |
| 748 | + | |
746 | 749 | | |
747 | | - | |
748 | | - | |
749 | 750 | | |
| 751 | + | |
750 | 752 | | |
751 | 753 | | |
752 | 754 | | |
753 | | - | |
754 | 755 | | |
755 | 756 | | |
756 | 757 | | |
| |||
0 commit comments