Repository navigation
Commit 7fdbe26
docs(drivers): record the bare-scheme-vs-local-filename decision (#1238 last thread)
Documents the maintainer decision on #1238's remaining open thread
(file-store.ts:61 — narrowing the bare-scheme exclusion to a closed list
broke forwarding for an unlisted custom DuckDB extension's bare-scheme
target). Decision: accept the closed-list default.
- file-store.ts: expanded the comment at NON_SLASH_REMOTE_SCHEMES to state
the fundamental ambiguity (a bare word:target cannot be told apart
syntactically from a local filename with a colon), why the closed list was
chosen over the broad heuristic (local filenames with colons are the common
case; known extensions are enumerable), and the escape hatch (use the
extension's scheme:// form, or extend the list when a new extension is
adopted).
- docs/configure/warehouses.md: new note in the DuckDB section explaining
bare word:target values are treated as local files unless the prefix is one
of the recognized bare schemes (md:, motherduck:, ducklake:).
- docs/drivers.md: one-sentence pointer to the same rule alongside the
existing file-backed-driver path notes.
Gates: packages/drivers file-store-guard tests 27/27 pass, bun turbo
typecheck 13/13 (forced, 0 cached), marker check --base origin/main --strict
clean, prettier clean on file-store.ts (the two docs files were already
unformatted on origin/main before this change, left as-is).
Co-Authored-By: Claude Opus 4.8 <[email protected]>
Claude-Session: https://claude.ai/code/session_01VqnuBDGkh1ZT65Ti7e6DHZ1 parent 7f5ebb9 commit 7fdbe26
3 files changed
Lines changed: 32 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
283 | 283 | | |
284 | 284 | | |
285 | 285 | | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
286 | 295 | | |
287 | 296 | | |
288 | 297 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
194 | 194 | | |
195 | 195 | | |
196 | 196 | | |
197 | | - | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
198 | 201 | | |
199 | 202 | | |
200 | 203 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
24 | 43 | | |
25 | 44 | | |
26 | 45 | | |
| |||
0 commit comments