You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 7a02983
Browse filesBrowse the repository at this point in the historyBrowse files
authored
fix(ci): validate cached dbt e2e environments; pin the uv venv to the system Python (#1258)
* fix(ci): validate cached dbt e2e environments; pin the uv venv to the system Python
The dbt-tools E2E job on main fails with ENOENT executing
test/.dbt-resolve-envs/uv/.venv/bin/dbt: the restored cache holds a uv venv
whose bin/python links to a uv-managed interpreter outside the cached
directory, absent on a fresh runner. setup-resolve.sh trusted the .done
marker and skipped setup, and actions/cache never re-saves on a hit, so the
broken environment came back on every run.
- setup-resolve.sh: a cached environment counts only if its dbt --version
runs (with a timeout); otherwise it is rebuilt. Applied to every scenario.
- uv venv is created with --python "$REAL_PYTHON" so it links to an
interpreter that exists on every runner.
- ci.yml: cache key bumped to -v2 so the broken v1 cache is not restored.
Closes#1257
Co-Authored-By: Claude Fable 5.1 <[email protected]>
* ci: run the dbt-tools E2E job on pull requests that touch packages/dbt-tools
The job ran only on push to main, so a PR fixing its environment setup could
not prove the fix before merging. The `dbt-tools` change filter already
existed for exactly this; the job now honours it, keeping the 3-minute cost
to PRs that change dbt-tools.
Co-Authored-By: Claude Fable 5.1 <[email protected]>
* ci(e2e): review fixes — gtimeout fallback, setup-python interpreter, read-only token
- setup-resolve.sh: `with_timeout` falls back to Homebrew's `gtimeout` on
macOS, so the cached-env check is bounded there too (cubic).
- setup-resolve.sh: `find_real_python` honours `DBT_E2E_PYTHON`; the workflow
sets it to the interpreter actions/setup-python installed, so the scenario
venvs no longer build on the runner image's /usr/bin/python3 while the
workflow believes it chose 3.11 (CodeRabbit).
- ci.yml: the E2E job now runs pull-request code, so it gets
`permissions: contents: read` and `persist-credentials: false`, matching
the tracker-leaks job (CodeRabbit).
Co-Authored-By: Claude Fable 5.1 <[email protected]>
* fix(ci): rebuild stale dbt version venvs; stop the versions suite skipping
- setup-versions.sh rebuilds a cached venv whose dbt does not run
- key both caches on the setup-python version
- versions test fails on a missing requested version, and points dbt-cli at each venv
- job timeout 20 min
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Claude-Session: https://claude.ai/code/session_0174HUYiaceApqHP7EKMNgnb
* ci: keep the dbt-tools E2E job at 10 min
The full run takes about 4 min in CI on a cache miss (tests 128 s), so the
original limit fits.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Claude-Session: https://claude.ai/code/session_0174HUYiaceApqHP7EKMNgnb
* fix(ci): trust a cached dbt venv only if it runs and reports its version
- setup-versions.sh requires `dbt --version` to exit 0 and report the
requested minor; otherwise it rebuilds
- the versions guard compares the version each dbt reports, not dir names
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Claude-Session: https://claude.ai/code/session_0174HUYiaceApqHP7EKMNgnb
---------
Co-authored-by: Claude Fable 5.1 <[email protected]>
Co-authored-by: Ralph Sto. Domingo <[email protected]>
0 commit comments