Repository navigation
Commit 77256d0
fix(workspace): three review findings on skill publish
**A symlinked skill directory defeated the managed-snapshot check.**
`path.resolve` is lexical: it normalises `..` and absolutises, but it does not
follow links. So a skill directory that IS a link into `.altimate-code/skill/
_workspace` resolved to its own path, passed `isManagedSkill`, and the bundle
walk then followed the link — publishing the workspace's own skills back to it
under the user's name. Compared through `realpathSync` now, falling back to the
lexical form for a path that does not exist, which cannot be a link into the
snapshot anyway.
**The bundle size guard could not stop the thing it exists to stop.**
`collectBundle` read each file with `readFile` and only then checked the running
total, so a single oversized file was pulled entirely into memory before being
rejected. Size is checked before the read now; the cumulative check stays for
many small files and as a backstop if the file grows in between.
**A conflicting rename on the update path surfaced a raw API envelope.**
The POST path maps 409 to `SkillNameConflictError`; the PATCH path only handled
`NotFoundError`, so renaming a skill onto a name this creator already uses
reached the caller as the server's own error shape — the exact outcome the typed
errors in this module exist to prevent, and invisible from the create path.
Tests: 14 in this file, 3 new, whole altimate suite green.
Worth recording how the tests were arrived at, because the first versions were
worthless: all three mutations SURVIVED. Asserting that an oversized bundle is
rejected does not test this fix — the post-read check rejects it too — so the
test now patches `readFile` and asserts the oversized file is never read at all.
The other two had no coverage whatsoever. All three mutations fail now.
Co-Authored-By: Claude Opus 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_012Q51zFUmPg1WwtS5CrGJE61 parent 79f77e1 commit 77256d0
2 files changed
Lines changed: 104 additions & 3 deletions
File tree
- packages/opencode
- src/altimate/workspace
- test/altimate/workspace
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
| 36 | + | |
36 | 37 | | |
37 | 38 | | |
38 | 39 | | |
| |||
125 | 126 | | |
126 | 127 | | |
127 | 128 | | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
128 | 138 | | |
129 | 139 | | |
130 | 140 | | |
| |||
148 | 158 | | |
149 | 159 | | |
150 | 160 | | |
151 | | - | |
152 | | - | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
153 | 178 | | |
154 | 179 | | |
155 | 180 | | |
| |||
257 | 282 | | |
258 | 283 | | |
259 | 284 | | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
260 | 290 | | |
261 | 291 | | |
262 | 292 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
10 | 19 | | |
| 20 | + | |
11 | 21 | | |
12 | 22 | | |
13 | 23 | | |
| |||
210 | 220 | | |
211 | 221 | | |
212 | 222 | | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
0 commit comments