Repository navigation
Commit 764291c
fix(question): close stdin stall + test isolation gap from PR #937 review
Two small fixes flagged by coderabbit + cubic on the prior commit
(d2a8516).
- `run.ts:459`: the `!process.stdin?.isTTY` null-safety guard turned a
crash (undefined stdin) into a stall (we still entered the branch
and awaited `Bun.stdin.text()` on a stream that would never EOF).
Use `process.stdin && !process.stdin.isTTY` so undefined stdin
skips the read entirely — the only sensible behavior in an embedded
runtime where there is no stdin to read from.
- `question.test.ts`: the `tool.question non-interactive auto-answer`
describe block sets `ALTIMATE_NON_INTERACTIVE=1` in beforeEach but
didn't clear `ALTIMATE_FORCE_INTERACTIVE`. A parent-shell export
could silently flip the suite to the interactive path and lose
non-interactive coverage. Delete in both hooks.
Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>1 parent d2a8516 commit 764291c
2 files changed
Lines changed: 11 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
454 | 454 | | |
455 | 455 | | |
456 | 456 | | |
457 | | - | |
458 | | - | |
459 | | - | |
| 457 | + | |
| 458 | + | |
| 459 | + | |
| 460 | + | |
| 461 | + | |
| 462 | + | |
| 463 | + | |
460 | 464 | | |
461 | 465 | | |
462 | 466 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
117 | 117 | | |
118 | 118 | | |
119 | 119 | | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
120 | 123 | | |
121 | 124 | | |
122 | 125 | | |
123 | 126 | | |
124 | 127 | | |
| 128 | + | |
125 | 129 | | |
126 | 130 | | |
127 | 131 | | |
| |||
0 commit comments