Repository navigation
Commit 5de0acf
committed
fix(workspace): an answer names an engine that is there, and is true when it is given
Two holes in the questions every named answer asks.
A client that vanished is not a client that was replaced. `confirmServing`
compared the runtime's launch record against the engine that was judged,
but treated NO record as agreement — so a client removed or disconnected
during the tool listing or the allowlist lookup was still answered
`attached` or `reused`. The record is the only witness to "still serving";
its absence is now the verdict `gone`, handled at both callers like a
replacement: the install is undone, the reuse answer is `superseded`, and
nothing is detached because nothing is there. A harness that does not model
the record is not asked.
The attached answer was fixed before the success announcements and given
after them, and the announcements are three awaits. A re-link, a disable or
a replacement landing inside them left this turn holding `attached` for an
engine that no longer served the bound workspace — the one residual the
install region still named. Every await after a guard belongs to the guard:
the world is asked once more after the last announcement, and the install
is undone and answered `superseded` if it moved. The toast was true when it
was shown; the answer is true when it is given; no second toast.
The test that asserted the residual now asserts its closure; a read-count
fixture gains the fourth intent read of the first attach. Removing the
`gone` verdict fails two named tests; removing the post-announcement check
fails three.1 parent 37cabe5 commit 5de0acf
4 files changed
Lines changed: 105 additions & 21 deletions
File tree
- packages/opencode
- src/altimate/workspace
- test/altimate/workspace
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
680 | 680 | | |
681 | 681 | | |
682 | 682 | | |
683 | | - | |
| 683 | + | |
684 | 684 | | |
685 | 685 | | |
686 | | - | |
687 | | - | |
| 686 | + | |
| 687 | + | |
| 688 | + | |
| 689 | + | |
| 690 | + | |
| 691 | + | |
| 692 | + | |
| 693 | + | |
| 694 | + | |
| 695 | + | |
688 | 696 | | |
689 | 697 | | |
690 | 698 | | |
| |||
1095 | 1103 | | |
1096 | 1104 | | |
1097 | 1105 | | |
1098 | | - | |
1099 | | - | |
1100 | | - | |
1101 | | - | |
| 1106 | + | |
| 1107 | + | |
| 1108 | + | |
| 1109 | + | |
| 1110 | + | |
1102 | 1111 | | |
| 1112 | + | |
1103 | 1113 | | |
1104 | 1114 | | |
1105 | 1115 | | |
| |||
1457 | 1467 | | |
1458 | 1468 | | |
1459 | 1469 | | |
| 1470 | + | |
| 1471 | + | |
| 1472 | + | |
| 1473 | + | |
| 1474 | + | |
| 1475 | + | |
| 1476 | + | |
| 1477 | + | |
| 1478 | + | |
| 1479 | + | |
| 1480 | + | |
| 1481 | + | |
| 1482 | + | |
| 1483 | + | |
| 1484 | + | |
| 1485 | + | |
1460 | 1486 | | |
1461 | 1487 | | |
1462 | 1488 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1314 | 1314 | | |
1315 | 1315 | | |
1316 | 1316 | | |
| 1317 | + | |
| 1318 | + | |
| 1319 | + | |
| 1320 | + | |
| 1321 | + | |
| 1322 | + | |
| 1323 | + | |
| 1324 | + | |
| 1325 | + | |
| 1326 | + | |
| 1327 | + | |
| 1328 | + | |
| 1329 | + | |
| 1330 | + | |
| 1331 | + | |
| 1332 | + | |
| 1333 | + | |
| 1334 | + | |
| 1335 | + | |
| 1336 | + | |
| 1337 | + | |
| 1338 | + | |
| 1339 | + | |
| 1340 | + | |
| 1341 | + | |
| 1342 | + | |
| 1343 | + | |
| 1344 | + | |
| 1345 | + | |
| 1346 | + | |
| 1347 | + | |
| 1348 | + | |
| 1349 | + | |
| 1350 | + | |
| 1351 | + | |
| 1352 | + | |
| 1353 | + | |
| 1354 | + | |
| 1355 | + | |
| 1356 | + | |
| 1357 | + | |
| 1358 | + | |
| 1359 | + | |
| 1360 | + | |
| 1361 | + | |
| 1362 | + | |
| 1363 | + | |
| 1364 | + | |
| 1365 | + | |
| 1366 | + | |
| 1367 | + | |
| 1368 | + | |
| 1369 | + | |
| 1370 | + | |
| 1371 | + | |
| 1372 | + | |
1317 | 1373 | | |
1318 | 1374 | | |
1319 | 1375 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
293 | 293 | | |
294 | 294 | | |
295 | 295 | | |
296 | | - | |
297 | | - | |
| 296 | + | |
| 297 | + | |
298 | 298 | | |
299 | 299 | | |
300 | 300 | | |
301 | 301 | | |
302 | 302 | | |
303 | 303 | | |
304 | | - | |
305 | | - | |
306 | | - | |
307 | | - | |
308 | | - | |
309 | | - | |
310 | | - | |
311 | | - | |
312 | | - | |
313 | | - | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
314 | 313 | | |
315 | | - | |
| 314 | + | |
316 | 315 | | |
317 | 316 | | |
318 | 317 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
639 | 639 | | |
640 | 640 | | |
641 | 641 | | |
642 | | - | |
| 642 | + | |
| 643 | + | |
| 644 | + | |
| 645 | + | |
643 | 646 | | |
644 | 647 | | |
645 | 648 | | |
| |||
0 commit comments