Skip to content

Commit 5bfb231

Browse files
fix(ci): typecheck every workspace on PRs and main (#1413)
* ci: typecheck every workspace on PRs and main `bun turbo typecheck` ran only at release and in the pre-push hook, so a type error from two PRs that each passed alone reached main unnoticed. Add a Typecheck job, and give trace-context-loop's MCP mock the `listMeta` and `snapshot` members the interface gained in the same window. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_0174HUYiaceApqHP7EKMNgnb * fix(ci): run the typecheck filter on turbo.json and bunfig.toml changes Both shape what `bun turbo typecheck` does (the task definition and the install it runs on), so a PR touching only them skipped the new job. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_0174HUYiaceApqHP7EKMNgnb * fix(ci): drop the mock fix that main already has main gained the same two `MCP.Service` mock members in #1405, at a different spot in the object, so merging both left duplicate keys (TS1117). Keep main's copy; this PR is now only the Typecheck job. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_0174HUYiaceApqHP7EKMNgnb --------- Co-authored-by: Claude Opus 5.5 (1M context) <[email protected]>
1 parent 9f13010 commit 5bfb231

1 file changed

Lines changed: 46 additions & 0 deletions

File tree

‎.github/workflows/ci.yml‎

Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,11 @@ jobs:
5252
- 'bun.lock'
5353
- 'package.json'
5454
- 'tsconfig.json'
55+
# altimate_change start — the Typecheck job runs `bun turbo typecheck`: turbo.json
56+
# defines that task and bunfig.toml shapes the install it runs on.
57+
- 'turbo.json'
58+
- 'bunfig.toml'
59+
# altimate_change end
5560
drivers:
5661
- 'packages/drivers/src/**'
5762
- 'packages/opencode/src/altimate/native/connections/**'
@@ -124,6 +129,47 @@ jobs:
124129
run: bun script/check-tracker-leaks.ts
125130
# altimate_change end
126131

132+
# altimate_change start — typecheck every workspace on PRs and on main.
133+
# ---------------------------------------------------------------------------
134+
# `bun turbo typecheck` ran only in release.yml and in the local pre-push hook,
135+
# and the TypeScript job below runs tests, not the compiler. So nothing in CI
136+
# caught two PRs that each passed on their own leaving main with a type error
137+
# together; it surfaced as every developer's pre-push failing after they
138+
# merged main, and would have failed the next release.
139+
typecheck:
140+
name: Typecheck
141+
needs: changes
142+
if: needs.changes.outputs.typescript == 'true' || github.event_name == 'push'
143+
runs-on: ubuntu-latest
144+
timeout-minutes: 15
145+
permissions:
146+
contents: read
147+
steps:
148+
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
149+
with:
150+
persist-credentials: false
151+
152+
- uses: oven-sh/setup-bun@ecf28ddc73e819eb6fa29df6b34ef8921c743461 # v2
153+
with:
154+
bun-version: "1.3.14"
155+
156+
- name: Cache Bun dependencies
157+
uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4
158+
with:
159+
path: ~/.bun/install/cache
160+
key: bun-${{ runner.os }}-${{ hashFiles('bun.lock') }}
161+
restore-keys: |
162+
bun-${{ runner.os }}-
163+
164+
- name: Install dependencies
165+
run: bun install
166+
167+
# The same command as release.yml's gate and the pre-push hook, so all
168+
# three agree on what "typechecks" means.
169+
- name: Typecheck
170+
run: bun turbo typecheck
171+
# altimate_change end
172+
127173
# Main TypeScript tests — excludes driver E2E tests (separate job) and
128174
# cloud credential tests (local-only).
129175
# ---------------------------------------------------------------------------

0 commit comments

Comments
 (0)