Repository navigation
Commit 59fe1e4
committed
fix(review): [R20 S1] qualify source-table entity names as
Two sources both containing a table named `orders` (e.g. `raw.orders`
and `legacy.orders`) previously conflated in `iterateGrainEntities`:
- Grain-change detection collapsed them into a single map entry, so a
change in one source's grain declaration could surface or suppress
gaps for the other.
- Finding fingerprint uses the entity name; two distinct source tables
with the same table name would dedupe to a single finding.
Fix: `iterateGrainEntities` now returns `{name, body}` pairs. Source
tables are qualified as `${sourceName}.${tableName}` while models,
snapshots, and seeds retain their unqualified name (they live in a
flat namespace already).
Tests: `grain detector also covers source tables` updated to assert
the qualified name; new test `same source-table name in two sources
does NOT conflate` locks in the fix.
257/257 review-* tests pass.<source>.<table> (cubic-review P2)1 parent 089a8bc commit 59fe1e4
2 files changed
Lines changed: 61 additions & 12 deletions
File tree
- packages/opencode
- src/altimate/review
- test/altimate
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
962 | 962 | | |
963 | 963 | | |
964 | 964 | | |
965 | | - | |
966 | | - | |
| 965 | + | |
| 966 | + | |
967 | 967 | | |
968 | 968 | | |
969 | 969 | | |
970 | 970 | | |
971 | | - | |
| 971 | + | |
| 972 | + | |
| 973 | + | |
| 974 | + | |
972 | 975 | | |
973 | 976 | | |
974 | 977 | | |
975 | 978 | | |
| 979 | + | |
| 980 | + | |
| 981 | + | |
976 | 982 | | |
977 | 983 | | |
978 | 984 | | |
979 | 985 | | |
980 | | - | |
| 986 | + | |
| 987 | + | |
| 988 | + | |
| 989 | + | |
981 | 990 | | |
982 | 991 | | |
983 | | - | |
| 992 | + | |
| 993 | + | |
| 994 | + | |
| 995 | + | |
984 | 996 | | |
985 | 997 | | |
986 | 998 | | |
| |||
999 | 1011 | | |
1000 | 1012 | | |
1001 | 1013 | | |
1002 | | - | |
1003 | | - | |
1004 | | - | |
| 1014 | + | |
1005 | 1015 | | |
1006 | 1016 | | |
1007 | 1017 | | |
| |||
1087 | 1097 | | |
1088 | 1098 | | |
1089 | 1099 | | |
1090 | | - | |
1091 | | - | |
1092 | | - | |
| 1100 | + | |
1093 | 1101 | | |
1094 | 1102 | | |
1095 | 1103 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
957 | 957 | | |
958 | 958 | | |
959 | 959 | | |
960 | | - | |
| 960 | + | |
| 961 | + | |
| 962 | + | |
961 | 963 | | |
962 | 964 | | |
963 | 965 | | |
| 966 | + | |
| 967 | + | |
| 968 | + | |
| 969 | + | |
| 970 | + | |
| 971 | + | |
| 972 | + | |
| 973 | + | |
| 974 | + | |
| 975 | + | |
| 976 | + | |
| 977 | + | |
| 978 | + | |
| 979 | + | |
| 980 | + | |
| 981 | + | |
| 982 | + | |
| 983 | + | |
| 984 | + | |
| 985 | + | |
| 986 | + | |
| 987 | + | |
| 988 | + | |
| 989 | + | |
| 990 | + | |
| 991 | + | |
| 992 | + | |
| 993 | + | |
| 994 | + | |
| 995 | + | |
| 996 | + | |
| 997 | + | |
| 998 | + | |
| 999 | + | |
| 1000 | + | |
| 1001 | + | |
| 1002 | + | |
| 1003 | + | |
| 1004 | + | |
964 | 1005 | | |
965 | 1006 | | |
966 | 1007 | | |
| |||
0 commit comments