You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 5224705
Browse filesBrowse the repository at this point in the historyBrowse files
fix(check): address bot review — .ddl in default glob, dotfile edge, isFile check, handler test + close#1130
Round 2 on the release/v0.9.6 hotfix — addresses the 5 bot findings on
PR #1131 and rolls in the follow-up filed as issue #1130.
- coderabbit MAJOR + cubic P2 (default-discovery gap): `**/*.sql` glob at
check.ts:462 missed `.ddl` files that the new SQL_EXTENSIONS filter
accepts. Now scans both extensions and dedupes.
- cubic P2 (bare-extension dotfile): `isSqlFile` accepted files named
literally `.sql` and `.ddl` as if the leading dot were an extension
separator. Node's `path.extname` treats those as dotfiles with NO
extension. Fixed to match: bare-`.sql`/`.ddl` filenames are rejected.
- cubic P2 (directory with .sql suffix): a directory named `foo.sql`
passed the extension filter. Added a `statSync(f).isFile()` gate that
rejects directories (and symlinks-to-directories, since statSync
follows symlinks) with a clear warning.
- cubic P2 (test coverage gap): the `isSqlFile` tests only exercised
the pure helper; if the CLI handler stopped calling the filter the
tests would still pass. Added a handler-level integration test with
mixed SQL/non-SQL input that asserts the warning is printed and no
content leaks. Also added handler tests for the directory + bare
dotfile cases. Updated the pre-existing "handles directory with .sql
extension" test to match the new isFile behavior (was expecting
"Error reading" from the downstream readFile crash).
- #1130 follow-up (drop env-var mutation from dispatcher test files):
removed the `beforeAll`/`afterAll` that mutated
`process.env.ALTIMATE_TELEMETRY_DISABLED` in
`test/altimate/dispatcher.test.ts` and
`test/skill/release-v0.9.6-adversarial.test.ts`. Dispatcher.call
already wraps every Telemetry.track in try/catch that swallows errors
— the env-var was defensive against nothing and wasn't parallel-safe.
Closes#1130.
Verification:
- 101/101 tests in check-e2e + dispatcher + release-adversarial pass
- rebuilt darwin-arm64 binary; sanity reproduction still shows no leak
- typecheck clean; marker guard clean
Closes#1130
Co-Authored-By: Claude Opus 4.7 <[email protected]>
0 commit comments