Repository navigation
Commit 4caaee0
committed
test+tool: [v0.9.4-consensus-m3+m5+m6] observable retry; wider staleness guard; drop unreachable sentinel
Three fixes from the consensus review of PR #1053.
**m3 — cli-process.ts SQLite retry observability**: the retry was
silent on the retry path, so a systematic regression from transient
lock contention would keep the suite green — defeating the point of
the harness. Added a `console.warn` that names the failure class and
the "if you see this often, contention has moved from transient to
systematic" signal, so a repeated pattern is visible in CI logs.
**m5 — smoke-test-binary staleness guard walks src/ + script/**: the
prior guard compared only against `script/build.ts`. That catches the
rare "build logic changed" case but MISSES the common "src/ changed"
case — after a `git pull` that only touches source, the guard would
still say the binary is fresh and run assertions against a stale
build. Rewrote `isBinaryStale()` to walk both trees, skipping
`node_modules` / `.turbo` / `dist` / hidden dirs, and looking at
files that actually contribute to the compiled binary (`*.ts{,x}`,
`*.json`, `*.txt`, `*.md`).
**m6 — sample_setup error metadata: revert suffix: -1 → 0**: the
sentinel guarded a collision no consumer can reach. Error-path
`output` contains no `suffix:` line at all (it's `status: error\n
reason: ...\n\n${message}`), and the template branches on `status:
error` first. `success: false` is the true disambiguator for
metadata readers. Reverted the sentinel and updated the comment to
reflect the actual disambiguation contract.1 parent 790df9b commit 4caaee0
3 files changed
Lines changed: 77 additions & 16 deletions
File tree
- packages/opencode
- src/altimate/tools
- test
- install
- lib
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
109 | 109 | | |
110 | 110 | | |
111 | 111 | | |
112 | | - | |
113 | | - | |
114 | | - | |
115 | | - | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
116 | 120 | | |
117 | 121 | | |
118 | 122 | | |
| |||
173 | 177 | | |
174 | 178 | | |
175 | 179 | | |
176 | | - | |
177 | | - | |
178 | | - | |
179 | | - | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
180 | 188 | | |
181 | 189 | | |
182 | 190 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
89 | 89 | | |
90 | 90 | | |
91 | 91 | | |
92 | | - | |
93 | | - | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
94 | 95 | | |
95 | 96 | | |
96 | 97 | | |
97 | 98 | | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
98 | 139 | | |
99 | 140 | | |
100 | | - | |
101 | | - | |
102 | 141 | | |
103 | | - | |
104 | | - | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
105 | 145 | | |
106 | 146 | | |
107 | 147 | | |
| |||
117 | 157 | | |
118 | 158 | | |
119 | 159 | | |
120 | | - | |
| 160 | + | |
121 | 161 | | |
122 | 162 | | |
123 | 163 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
299 | 299 | | |
300 | 300 | | |
301 | 301 | | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
302 | 310 | | |
303 | 311 | | |
304 | | - | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
305 | 318 | | |
306 | 319 | | |
307 | 320 | | |
| |||
0 commit comments