You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 42a6251
Browse filesBrowse the repository at this point in the historyBrowse files
Codex review of the release-hardening commit found fail-open paths; all fixed:
- skill/RELEASING.md: tag verification now aborts (`|| exit 1`) instead of
echo-and-continue; stage-`tag` preflight moved AFTER the release commit
(it previously ran against a tree dirtied by the CHANGELOG edit and could
never pass); `cd` blocks made subshells so repo-root paths stay valid;
smoke test builds with `OPENCODE_VERSION` injected and asserts equality
- `release-preflight.ts`: npm publish-check only treats E404 as "not
published" (other errors FAIL); `gh` errors FAIL (WARN only when the
binary is missing); malformed `gh` JSON FAILs instead of double-reporting;
`run()` no longer throws on missing binaries; SemVer prerelease compare is
numeric-aware (`beta.10` > `beta.2`); `selectPrevTag` picks the greatest
stable tag strictly LOWER than the target (a merged fork-inherited
`v1.18.3` must not become PREV_TAG for `v0.9.x`) — same fix applied to
`release.yml`'s PREV_TAG loop
- `/release-beta`: wires in the preflight (`--allow-prerelease`) and
fail-closed tag collision checks before pushing the beta tag
- tests: 34 -> 38 (numeric prerelease precedence, prefix ranking,
fork-inherited higher-tag exclusion)
Co-Authored-By: Claude Fable 5 <[email protected]>
Copy file name to clipboardExpand all lines: .claude/commands/release.md
+19-14Lines changed: 19 additions & 14 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -229,12 +229,12 @@ When running the full suite in the background, tee complete output to a file (`b
229
229
230
230
### 7a: Smoke test the ACTUAL release candidate
231
231
232
-
Never smoke-test the `$PATH`-resolved `altimate` — in v0.9.2 it silently validated a stale globally-installed 0.7.3. Build and run the real artifact:
232
+
Never smoke-test the `$PATH`-resolved `altimate` — in v0.9.2 it silently validated a stale globally-installed 0.7.3. Build with the target version injected (otherwise the binary reports a `0.0.0-…` preview version and no assertion is possible), then assert the exact version. Run from the repo root; use a subshell for the `cd` so later paths still resolve:
233
233
234
234
```bash
235
-
cd packages/opencode && bun run pre-release# builds dist + checks NAPI externals + binary starts
235
+
(cd packages/opencode &&OPENCODE_VERSION={NEXT_VERSION} bun run pre-release)
236
236
BINARY=$(find packages/opencode/dist -path '*bin/altimate*' -type f | head -1)
237
-
"$BINARY" --version# MUST print a version consistent with this release, not a stale install
# Pre-release sanity (binary builds and starts) — if not already run in Step 7a
283
-
cd packages/opencode && bun run pre-release
284
-
285
-
# Full preflight again, now tolerating local release commits ahead of origin/main
286
-
bun script/release-preflight.ts --version {NEXT_VERSION} --stage tag
283
+
(cd packages/opencode && OPENCODE_VERSION={NEXT_VERSION} bun run pre-release)
287
284
```
288
285
286
+
(The stage-`tag` preflight runs in Step 10, AFTER the release commit — running it here would fail its clean-worktree check on the just-edited CHANGELOG.)
287
+
289
288
**Exit-status integrity rule:** never background a gate command with a trailing status echo (`cmd > log; echo "exit: $?"` — the echo always exits 0 and once turned a FAILED pre-release build into a reported pass). Preserve the real exit code: run in foreground, or `cmd 2>&1 | tee log` and check `$pipestatus[1]`/`PIPESTATUS[0]`, and ALWAYS read the tool's own verdict line from the log.
290
289
291
290
**Gate: ALL CHECKS MUST PASS.** Stop on failure.
@@ -302,9 +301,9 @@ docker compose -f test/sanity/docker-compose.verdaccio.yml up \
302
301
303
302
If Docker unavailable, skip — but mark it ⏭️ in the Step 12 summary (it was once skipped silently). CI will catch it.
304
303
305
-
## Step 10: Commit, Tag, Push — three verified steps, one atomic push
Do NOT chain these with `&&` into one command (a mid-chain tag failure once committed but silently never pushed). Verify each stage:
306
+
Do NOT chain these with `&&` into one command (a mid-chain tag failure once committed but silently never pushed). Run each from the repo root and verify each stage:
308
307
309
308
```bash
310
309
# 1. Commit (targeted staging only — never `git add -A`, worktrees carry scratch files)
# Atomic: branch and tag land together or not at all.
88
101
git push --atomic origin HEAD:main v0.5.0
89
102
```
90
103
91
-
### 4. What happens automatically
104
+
### 5. What happens automatically
92
105
93
106
The `v*` tag triggers `.github/workflows/release.yml` which:
94
107
@@ -100,7 +113,7 @@ The `v*` tag triggers `.github/workflows/release.yml` which:
100
113
6.**Publishes Docker image (best-effort)** — to `ghcr.io/altimateai/altimate-code`; failures are logged but do NOT fail the release, so verify manually if you need the image
101
114
7.~~Updates AUR~~ — currently **disabled** (the workflow step is commented out; see `publish.ts` for setup steps to re-enable)
0 commit comments