Skip to content

Commit 40f8e92

Browse files
suryaiyer95claude
andcommitted
fix: [AI-5975] ensure metadata.error is never undefined on success paths
- `complete`, `grade`: use conditional spread `...(error && { error })` to avoid setting `metadata.error = undefined` on success - `sql-explain`: remove `error` from success path metadata entirely, add `?? "Unknown error"` fallback to failure path - `finops-expensive-queries`, `finops-query-history`, `finops-unused-resources`, `finops-warehouse-advice`: add `?? "Unknown error"` fallback so metadata always has a concrete error string on failure Co-Authored-By: Claude Opus 4.6 <[email protected]>
1 parent c14852a commit 40f8e92

7 files changed

Lines changed: 20 additions & 13 deletions

File tree

‎packages/opencode/src/altimate/tools/altimate-core-complete.ts‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,10 @@ export const AltimateCoreCompleteTool = Tool.define("altimate_core_complete", {
2121
})
2222
const data = result.data as Record<string, any>
2323
const count = data.items?.length ?? data.suggestions?.length ?? 0
24+
const error = result.error ?? (data as any).error
2425
return {
2526
title: `Complete: ${count} suggestion(s)`,
26-
metadata: { success: result.success, suggestion_count: count, error: result.error ?? (data as any).error },
27+
metadata: { success: result.success, suggestion_count: count, ...(error && { error }) },
2728
output: formatComplete(data),
2829
}
2930
} catch (e) {

‎packages/opencode/src/altimate/tools/altimate-core-grade.ts‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,10 @@ export const AltimateCoreGradeTool = Tool.define("altimate_core_grade", {
2020
const data = result.data as Record<string, any>
2121
const grade = data.overall_grade ?? data.grade
2222
const score = data.scores?.overall != null ? Math.round(data.scores.overall * 100) : data.score
23+
const error = result.error ?? data.error
2324
return {
2425
title: `Grade: ${grade ?? "?"}`,
25-
metadata: { success: result.success, grade, score, error: result.error ?? data.error },
26+
metadata: { success: result.success, grade, score, ...(error && { error }) },
2627
output: formatGrade(data),
2728
}
2829
} catch (e) {

‎packages/opencode/src/altimate/tools/finops-expensive-queries.ts‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,10 +47,11 @@ export const FinopsExpensiveQueriesTool = Tool.define("finops_expensive_queries"
4747
})
4848

4949
if (!result.success) {
50+
const error = result.error ?? "Unknown error"
5051
return {
5152
title: "Expensive Queries: FAILED",
52-
metadata: { success: false, query_count: 0, error: result.error },
53-
output: `Failed to find expensive queries: ${result.error ?? "Unknown error"}`,
53+
metadata: { success: false, query_count: 0, error },
54+
output: `Failed to find expensive queries: ${error}`,
5455
}
5556
}
5657

‎packages/opencode/src/altimate/tools/finops-query-history.ts‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,10 +65,11 @@ export const FinopsQueryHistoryTool = Tool.define("finops_query_history", {
6565
})
6666

6767
if (!result.success) {
68+
const error = result.error ?? "Unknown error"
6869
return {
6970
title: "Query History: FAILED",
70-
metadata: { success: false, query_count: 0, error: result.error },
71-
output: `Failed to fetch query history: ${result.error ?? "Unknown error"}`,
71+
metadata: { success: false, query_count: 0, error },
72+
output: `Failed to fetch query history: ${error}`,
7273
}
7374
}
7475

‎packages/opencode/src/altimate/tools/finops-unused-resources.ts‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,10 +75,11 @@ export const FinopsUnusedResourcesTool = Tool.define("finops_unused_resources",
7575
})
7676

7777
if (!result.success) {
78+
const error = result.error ?? "Unknown error"
7879
return {
7980
title: "Unused Resources: FAILED",
80-
metadata: { success: false, unused_count: 0, error: result.error },
81-
output: `Failed to find unused resources: ${result.error ?? "Unknown error"}`,
81+
metadata: { success: false, unused_count: 0, error },
82+
output: `Failed to find unused resources: ${error}`,
8283
}
8384
}
8485

‎packages/opencode/src/altimate/tools/finops-warehouse-advice.ts‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,10 +83,11 @@ export const FinopsWarehouseAdviceTool = Tool.define("finops_warehouse_advice",
8383
})
8484

8585
if (!result.success) {
86+
const error = result.error ?? "Unknown error"
8687
return {
8788
title: "Warehouse Advice: FAILED",
88-
metadata: { success: false, recommendation_count: 0, error: result.error },
89-
output: `Failed to analyze warehouses: ${result.error ?? "Unknown error"}`,
89+
metadata: { success: false, recommendation_count: 0, error },
90+
output: `Failed to analyze warehouses: ${error}`,
9091
}
9192
}
9293

‎packages/opencode/src/altimate/tools/sql-explain.ts‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,16 +20,17 @@ export const SqlExplainTool = Tool.define("sql_explain", {
2020
})
2121

2222
if (!result.success) {
23+
const error = result.error ?? "Unknown error"
2324
return {
2425
title: "Explain: FAILED",
25-
metadata: { success: false, analyzed: false, warehouse_type: result.warehouse_type ?? "unknown", error: result.error },
26-
output: `Failed to get execution plan: ${result.error ?? "Unknown error"}`,
26+
metadata: { success: false, analyzed: false, warehouse_type: result.warehouse_type ?? "unknown", error },
27+
output: `Failed to get execution plan: ${error}`,
2728
}
2829
}
2930

3031
return {
3132
title: `Explain: ${result.analyzed ? "ANALYZE" : "PLAN"} [${result.warehouse_type ?? "unknown"}]`,
32-
metadata: { success: true, analyzed: result.analyzed, warehouse_type: result.warehouse_type ?? "unknown", error: result.error },
33+
metadata: { success: true, analyzed: result.analyzed, warehouse_type: result.warehouse_type ?? "unknown" },
3334
output: formatPlan(result),
3435
}
3536
} catch (e) {

0 commit comments

Comments
 (0)