Skip to content

Commit 40026d1

Browse files
test: the probe's no-telemetry check waits on the import, not a timer
Also restores the env variable it sets instead of deleting it. Co-Authored-By: Claude Fable 5.1 <[email protected]> Claude-Session: https://claude.ai/code/session_01YNasdD5tQMNtzXsuMEy82X (cherry picked from commit 38c790d)
1 parent 1cbcf2b commit 40026d1

1 file changed

Lines changed: 7 additions & 2 deletions

File tree

‎packages/opencode/test/altimate/telemetry/config-state.test.ts‎

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,14 +51,19 @@ describe("TelemetryConfig.disabledState (no Instance)", () => {
5151

5252
test("reading a config that uses env interpolation emits no telemetry", async () => {
5353
const track = spyOn(Telemetry, "track")
54+
const savedFlag = process.env.CONFIG_STATE_PROBE_FLAG
5455
try {
5556
process.env.CONFIG_STATE_PROBE_FLAG = "true"
5657
writeFileSync(globalFile(), '{ "telemetry": { "disabled": {env:CONFIG_STATE_PROBE_FLAG} }, "x": "${HOME}" }')
5758
expect(await TelemetryConfig.disabledState(dir)).toBe("disabled")
58-
await new Promise((r) => setTimeout(r, 50)) // the parser's row would arrive after a dynamic import
59+
// The parser tracks its row behind `import("@/altimate/telemetry")`. That module is loaded, so
60+
// awaiting the same import settles after any such callback queued during the read.
61+
await import("../../../src/altimate/telemetry")
62+
await Promise.resolve()
5963
expect(track.mock.calls.filter(([event]) => event.type === "config_env_interpolation")).toHaveLength(0)
6064
} finally {
61-
delete process.env.CONFIG_STATE_PROBE_FLAG
65+
if (savedFlag === undefined) delete process.env.CONFIG_STATE_PROBE_FLAG
66+
else process.env.CONFIG_STATE_PROBE_FLAG = savedFlag
6267
track.mockRestore()
6368
}
6469
})

0 commit comments

Comments
 (0)