Repository navigation
Commit 39718d5
committed
perf(review): address PR-1027 round-3 nits (deleted-file fetch, summary alloc, shift O(N²))
Three centralized-review findings on the previous commit `6729f5374`,
all perf/hygiene:
## MEDIUM — schema.yml orchestrator fetched `oldContent` for deleted files
`file.status !== "added"` on the gate matched `"deleted"` too, triggering
a `git show` round-trip whose result the detector immediately discarded
(early-returns `[]` for `status === "deleted"`).
Fix: filter deleted schema files out of the loop upfront —
`reviewable.filter((f) => f.kind === "schema_yml" && f.status !== "deleted")`.
The `newContent` fetch also simplifies to unconditional
`getContent?.(file.path, "new")` since deleted files never reach the loop.
## MEDIUM — `distinctModels`/`modelClause` recomputed on every loop iteration
The `[...new Set(...).filter(...).map(...).join(...)]` chain was evaluated
on every removal even though the result is only used when `shouldEmitSummary`
is true (once per file). Moved the computation inside the guard.
## LOW — `fallbackDiscriminators.shift()` inside the loop is O(N²)
`Array.prototype.shift()` re-indexes all remaining elements on each call.
Replaced with a hoisted `let fallbackIdx = 0` + `fallbackDiscriminators[fallbackIdx++]`.
Negligible on 2-3 removals but grows quadratically on wider PRs.
## Test status
188 pass / 0 fail across the 7 review test files. Typecheck clean. No
behavior change beyond the deleted-file fetch skip (which is a pure
performance improvement — same output, fewer round-trips).1 parent 6729f53 commit 39718d5
2 files changed
Lines changed: 25 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1050 | 1050 | | |
1051 | 1051 | | |
1052 | 1052 | | |
| 1053 | + | |
| 1054 | + | |
| 1055 | + | |
| 1056 | + | |
| 1057 | + | |
1053 | 1058 | | |
1054 | 1059 | | |
1055 | 1060 | | |
| |||
1096 | 1101 | | |
1097 | 1102 | | |
1098 | 1103 | | |
1099 | | - | |
| 1104 | + | |
| 1105 | + | |
| 1106 | + | |
1100 | 1107 | | |
1101 | | - | |
1102 | | - | |
1103 | | - | |
1104 | | - | |
1105 | | - | |
1106 | | - | |
1107 | | - | |
1108 | | - | |
| 1108 | + | |
| 1109 | + | |
| 1110 | + | |
| 1111 | + | |
| 1112 | + | |
| 1113 | + | |
| 1114 | + | |
| 1115 | + | |
| 1116 | + | |
1109 | 1117 | | |
1110 | 1118 | | |
1111 | 1119 | | |
1112 | 1120 | | |
1113 | 1121 | | |
1114 | 1122 | | |
1115 | 1123 | | |
1116 | | - | |
| 1124 | + | |
1117 | 1125 | | |
1118 | 1126 | | |
1119 | 1127 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1230 | 1230 | | |
1231 | 1231 | | |
1232 | 1232 | | |
1233 | | - | |
| 1233 | + | |
| 1234 | + | |
| 1235 | + | |
| 1236 | + | |
| 1237 | + | |
| 1238 | + | |
1234 | 1239 | | |
1235 | 1240 | | |
1236 | 1241 | | |
1237 | 1242 | | |
1238 | 1243 | | |
1239 | 1244 | | |
1240 | | - | |
| 1245 | + | |
1241 | 1246 | | |
1242 | 1247 | | |
1243 | 1248 | | |
| |||
0 commit comments