Repository navigation
Commit 33aa344
fix: [#834] address fourth-pass re-review — clarify lazy-subscribe semantics + accurate warn copy
Reviewer caught three documentation/copy issues that survived earlier passes:
1. Comment claimed "subscribing at module load is the established pattern"
but the code subscribes lazily on first call. Rewrote the comment block
to describe what the code actually does, plus the deliberate no-retry
trade-off on subscribe failure (silent retry would re-throw every call).
2. Warn message said "the list will be discarded if you exceed 50 calls."
Misleading — the refuse branch preserves the existing list (returns it
in metadata). Changed to "further updates will be refused" and added
"(Your current list is preserved.)" so the agent doesn't conclude its
work is at risk.
3. `clearTodoWriteCounter` had no documented access-control rationale.
Added one-line note that no auth check is needed (single local user,
no remote callers, same privilege boundary as any in-process import).
No behavior change — pure documentation + user-facing string.
12/12 tests pass; marker check clean.
Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>1 parent 1600efa commit 33aa344
1 file changed
Lines changed: 18 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
35 | | - | |
36 | | - | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
37 | 46 | | |
38 | 47 | | |
39 | 48 | | |
| |||
43 | 52 | | |
44 | 53 | | |
45 | 54 | | |
46 | | - | |
47 | | - | |
| 55 | + | |
48 | 56 | | |
49 | 57 | | |
50 | 58 | | |
| |||
80 | 88 | | |
81 | 89 | | |
82 | 90 | | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
83 | 95 | | |
84 | 96 | | |
85 | 97 | | |
| |||
175 | 187 | | |
176 | 188 | | |
177 | 189 | | |
178 | | - | |
179 | | - | |
| 190 | + | |
| 191 | + | |
180 | 192 | | |
181 | 193 | | |
182 | 194 | | |
| |||
0 commit comments