You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 310927e
Browse filesBrowse the repository at this point in the historyBrowse files
Four items from cubic-review round-3 + one CI-only test flake:
- **Deleted schema.yml handling (cubic P2)** — `detectSchemaYmlPatterns`
now diffs old YAML against `{}` when `status === "deleted"`, so
dropping a whole schema file surfaces every prior test as a removal.
`orchestrate.ts` no longer filters deleted files and skips
`newContent` fetch for them (git-show at HEAD would fail).
Two regression tests: 4-test deletion, and safe-degrade when
`oldContent` is missing.
- **Backtick-safe tierReasons rendering (cubic P3)** — `format.ts`
now sizes the inline-code-span fence to `max(backtick-run) + 1`
and pads leading/trailing backticks with a space, so paths like
`` `foo`bar` `` can't terminate the span or inject Markdown.
Regression test covers single/double/leading/trailing/both-ends cases.
- **Structured attribution on removal findings (cubic P3)** —
`removed_tests` findings now include `model` and `column` on the
top-level Finding, not just inside `evidence.result`, so downstream
dedupe / formatting / telemetry see them.
- **TUI network-options test flake (CI-only)** — Bun's transpiler
statically resolved the `@/cli/network` string literal in
`toContain('...')` into a `file:///…/network.ts` URL, inverting the
comparison. Rewritten as `toMatch(/regex/)` so the alias literal
isn't recognizable to Bun's analyzer.
Additional edge tests per codex round-4 review:
- Deleted schema.yml with unparsable oldContent → diff-only fallback.
- Deleted empty schema.yml → no fabricated findings.
- tierReasons with both leading + trailing backticks → symmetric padding.
Tests: 145 pass, 0 fail in touched suites; full review suite (188 tests) green.
Co-Authored-By: Claude Opus 4.7 <[email protected]>
Claude-Session: https://claude.ai/code/session_017zXDXMiNFh4qDPxPCfa2of
0 commit comments