Repository navigation
Commit 2be242d
fix(workspace): scope the published-skill ledger by account and serialise its writes
Two more from the cubic review on #1280. Both are the ledger describing
something other than what is actually on the server.
**One directory, two accounts, one id.** The ledger keyed on the resolved skill
directory alone, so publishing the same skill under a second account overwrote
the first account's record. Switching back found a row scoped to the other
tenant, treated the skill as unpublished, created it again — and 409'd on the
name that was already there, with the original id no longer reachable from this
machine. The key now carries tenant and API URL alongside the directory, so each
account keeps its own id. Reads still fall back to the old directory-only key,
so ids written by an earlier version are not stranded into a needless re-create;
the tenant check stays, because that fallback can return another account's row.
**Concurrent publishes dropped each other's ids.** Each publish read the whole
ledger, mutated its copy and wrote it back, so of two publishes in flight the
later write carried the earlier one away, and that skill created again on its
next run. Writes go through a promise chain now, and the re-read happens INSIDE
the chain — reusing a copy read before the previous write landed would lose it
just the same. Same shape `memory-index` already uses for the same reason.
Tests: 16 in this file, 2 new, whole altimate suite green (5799 tests).
Mutation-checked: keying by directory alone fails one, dropping the chain fails
four.
Co-Authored-By: Claude Opus 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_012Q51zFUmPg1WwtS5CrGJE61 parent 77256d0 commit 2be242d
2 files changed
Lines changed: 92 additions & 14 deletions
File tree
- packages/opencode
- src/altimate/workspace
- test/altimate/workspace
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
226 | 226 | | |
227 | 227 | | |
228 | 228 | | |
229 | | - | |
230 | | - | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
231 | 247 | | |
232 | | - | |
233 | | - | |
234 | | - | |
235 | | - | |
236 | | - | |
237 | | - | |
238 | | - | |
239 | | - | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
240 | 262 | | |
241 | 263 | | |
242 | 264 | | |
243 | 265 | | |
244 | 266 | | |
245 | | - | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
246 | 272 | | |
247 | | - | |
248 | | - | |
249 | | - | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
250 | 276 | | |
251 | 277 | | |
252 | 278 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
281 | 281 | | |
282 | 282 | | |
283 | 283 | | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
0 commit comments