Repository navigation
Commit 290f43d
fix(workspace): bot-review round 5 — no browser-handoff for already-linked project, tighter workspace_id spelling
Two #1100-only cycle-5 findings:
- **link.ts SET_UP_IN_BROWSER_SENTINEL** (CodeRabbit Major) — the browser
handoff option was offered even when the project was already linked;
``runBrowserHandoff`` then created a fresh workspace and 409'd on
``bindExisting``, stranding the workspace. Gate the option on ``!existing``
alongside ``browserAvailable``.
- **browser-handoff.ts workspace_id** (cubic P3) — ``Number()`` coerces
``"1e2"``, ``"0x2a"``, and ``" 42 "`` into finite integers, slipping past
the ``isInteger`` guard. Require a plain decimal-digit spelling first.
Test suite green (4072 pass across the altimate suite).
Co-Authored-By: Claude Opus 4.7 <[email protected]>
Claude-Session: https://claude.ai/code/session_016H42Vt4pt5dcD7opRqckeM1 parent b1a0de8 commit 290f43d
2 files changed
Lines changed: 19 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
256 | 256 | | |
257 | 257 | | |
258 | 258 | | |
259 | | - | |
260 | 259 | | |
261 | 260 | | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
262 | 273 | | |
263 | 274 | | |
264 | 275 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
115 | 115 | | |
116 | 116 | | |
117 | 117 | | |
118 | | - | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
119 | 125 | | |
120 | 126 | | |
121 | 127 | | |
| |||
0 commit comments