You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 282876b
Browse filesBrowse the repository at this point in the historyBrowse files
Addresses 5 substantive issues raised by the latest round of bot reviews.
### P1 / MAJOR
- **MySQL/MariaDB week-partition values no longer corrupted** (cubic P1,
data-diff.ts:610) — the prior ISO `yyyy-mm-dd` normalization applied to
every dialect silently rewrote MySQL `DATE_FORMAT(%Y-%u)` outputs like
`"2024-42"` into invalid dates, producing WHERE clauses that never
match. Scope the normalization to T-SQL / Fabric only — those use
`CONVERT(DATE, …, 23)` which is the only code path that requires ISO.
Postgres, MySQL, ClickHouse, BigQuery, Oracle all get the raw value
verbatim, matching their own `DATE_TRUNC`/`toStartOf*` output.
- **Partitioned diff no longer drops extra_columns** (coderabbit MAJOR,
data-diff.ts:824) — the partition fix wraps each side as a SELECT
subquery before recursing. `discoverExtraColumns` skips SQL queries
(only inspects plain table names), so the recursive `runDataDiff` fell
through to key-only comparison, silently losing value-level diffs.
Now `runPartitionedDiff` runs discovery ONCE on the plain source
table up-front and passes the resolved `extra_columns` explicitly to
each recursive call. Audit-column exclusion metadata is also
propagated to the aggregated result for user reporting.
### P2 / MINOR
- **`azure_resource_url` trailing slash normalized** (cubic P2,
sqlserver.ts:50) — an explicit `"https://custom-host"` (no slash)
would produce an invalid OAuth scope `"https://custom-host.default"`.
Enforce a trailing slash in `resolveAzureResourceUrl`.
- **`az account get-access-token` uses `execFile`** (coderabbit,
sqlserver.ts:200) — replaces `exec(<shell command string>)` with
`execFile("az", [args])` so user-supplied `azure_resource_url` can't
introduce shell metacharacters into the command string. Also updates
the test harness to stub both `exec` and `execFile`.
### Test isolation / coverage
- **Added same-dialect cross-warehouse joindiff test** (cubic,
data-diff-cross-dialect.test.ts:97) — two MSSQL servers with
different hosts must still be gated by the joindiff guard; previous
tests only exercised mixed dialects.
- **Added MySQL week-partition regression tests** — prevent future
revivals of the dialect-unaware ISO rewrite.
- **Added trailing-slash `azure_resource_url` test.**
Test results:
- 44/44 sqlserver driver tests pass
- 2824/2824 altimate tests pass, 0 fail
- Remaining full-suite failures (`mcp/`, `tool/project-scan`,
`plan-approval-phrase`) are pre-existing on `main`.
Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
0 commit comments