Repository navigation
Commit 27b3bb8
fix: escalate to SIGKILL in pty-tui dispose to avoid orphaned test children
The PTY test fixture's `dispose()` sent `SIGTERM` then waited up to 1000ms
for exit, but never escalated. A child that traps/ignores `SIGTERM` (or is
slow to tear down its render loop + worker) would be left orphaned when
`dispose()` returns — a silent test-process leak on CI. Add a `SIGKILL`
escalation after the grace window. The happy path (child exits cleanly
within the grace) is byte-for-byte unchanged.
Addresses the OpenCodeReview finding on
`packages/opencode/test/fixture/pty-tui.ts`.
Verified: typecheck clean; `phase-label.tui-e2e.test.ts` passes (fixture
launches + disposes cleanly).
Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Claude-Session: https://claude.ai/code/session_012WRxuYemV9xjUArbumGSUC1 parent 9b88a7f commit 27b3bb8
1 file changed
Lines changed: 16 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
217 | 217 | | |
218 | 218 | | |
219 | 219 | | |
220 | | - | |
221 | | - | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
222 | 236 | | |
223 | 237 | | |
224 | 238 | | |
| |||
0 commit comments