Skip to content

Commit 2625f42

Browse files
suryaiyer95claude
andcommitted
fix: mask error messages before sending to telemetry
Error messages from SQL engines can embed data values (e.g. "Value '[email protected]' does not match type INTEGER"). Apply maskString() to all error_message fields before transmission, consistent with how args are already masked. Affects: core_failure (tool.ts), sql_execute_failure (register.ts) Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
1 parent 94ac4ad commit 2625f42

3 files changed

Lines changed: 10 additions & 7 deletions

File tree

‎docs/docs/configure/telemetry.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ We collect the following categories of events:
3535
| `context_overflow_recovered` | Context overflow is handled (strategy) |
3636
| `skill_used` | A skill is loaded (skill name and source — `builtin`, `global`, or `project` — no skill content) |
3737
| `sql_execute_failure` | A SQL execution fails (warehouse type, query type, error message, PII-masked SQL — no raw values) |
38-
| `core_failure` | An internal library error occurs — function name, error category, error message (truncated to 500 chars), and arguments with PII and sensitive fields masked |
38+
| `core_failure` | An internal library error occurs — function name, error category, and error message and arguments with PII and sensitive fields masked |
3939

4040
Each event includes a timestamp, anonymous session ID, and the CLI version.
4141

‎packages/opencode/src/altimate/native/connections/register.ts‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -229,6 +229,7 @@ register("sql.execute", async (params: SqlExecuteParams): Promise<SqlExecuteResu
229229
return result
230230
} catch (e) {
231231
const errorMsg = String(e)
232+
const maskedErrorMsg = Telemetry.maskString(errorMsg).slice(0, 500)
232233
try {
233234
Telemetry.track({
234235
type: "warehouse_query",
@@ -240,7 +241,7 @@ register("sql.execute", async (params: SqlExecuteParams): Promise<SqlExecuteResu
240241
duration_ms: Date.now() - startTime,
241242
row_count: 0,
242243
truncated: false,
243-
error: errorMsg.slice(0, 500),
244+
error: maskedErrorMsg,
244245
error_category: categorizeQueryError(e),
245246
})
246247
Telemetry.track({
@@ -249,7 +250,7 @@ register("sql.execute", async (params: SqlExecuteParams): Promise<SqlExecuteResu
249250
session_id: Telemetry.getContext().sessionId,
250251
warehouse_type: warehouseType,
251252
query_type: detectQueryType(params.sql),
252-
error_message: errorMsg.slice(0, 500),
253+
error_message: maskedErrorMsg,
253254
masked_sql: Telemetry.maskString(params.sql),
254255
duration_ms: Date.now() - startTime,
255256
})

‎packages/opencode/src/tool/tool.ts‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@ export namespace Tool {
7676
// Telemetry must never prevent the original error from propagating
7777
try {
7878
const errorMsg = error instanceof Error ? error.message : String(error)
79+
const maskedErrorMsg = Telemetry.maskString(errorMsg).slice(0, 500)
7980
Telemetry.track({
8081
type: "tool_call",
8182
timestamp: Date.now(),
@@ -89,7 +90,7 @@ export namespace Tool {
8990
sequence_index: 0,
9091
previous_tool: null,
9192
input_signature: Telemetry.computeInputSignature(args as Record<string, unknown>),
92-
error: errorMsg.slice(0, 500),
93+
error: maskedErrorMsg,
9394
})
9495
Telemetry.track({
9596
type: "core_failure",
@@ -98,7 +99,7 @@ export namespace Tool {
9899
tool_name: id,
99100
tool_category: Telemetry.categorizeToolName(id, "standard"),
100101
error_class: Telemetry.classifyError(errorMsg),
101-
error_message: errorMsg.slice(0, 500),
102+
error_message: maskedErrorMsg,
102103
input_signature: Telemetry.computeInputSignature(args as Record<string, unknown>),
103104
masked_args: Telemetry.maskArgs(args as Record<string, unknown>),
104105
duration_ms: Date.now() - startTime,
@@ -137,15 +138,16 @@ export namespace Tool {
137138
const errorMsg =
138139
typeof result.metadata?.error === "string"
139140
? result.metadata.error
140-
: result.output?.slice(0, 500) || "unknown error"
141+
: result.output || "unknown error"
142+
const maskedErrorMsg = Telemetry.maskString(errorMsg).slice(0, 500)
141143
Telemetry.track({
142144
type: "core_failure",
143145
timestamp: Date.now(),
144146
session_id: ctx.sessionID,
145147
tool_name: id,
146148
tool_category: Telemetry.categorizeToolName(id, "standard"),
147149
error_class: Telemetry.classifyError(errorMsg),
148-
error_message: errorMsg.slice(0, 500),
150+
error_message: maskedErrorMsg,
149151
input_signature: Telemetry.computeInputSignature(args as Record<string, unknown>),
150152
masked_args: Telemetry.maskArgs(args as Record<string, unknown>),
151153
duration_ms: durationMs,

0 commit comments

Comments
 (0)