Skip to content

Commit 1e4c4e4

Browse files
suryaiyer95claude
andcommitted
fix: [AI-5975] treat "not equivalent" as valid result in altimate_core_equivalence
The handler returns `success: false` when queries are not equivalent, but "not equivalent" is a valid analysis result — not a failure. This was causing false `core_failure` telemetry events with "unknown error". Uses the same `isRealFailure = !!error` pattern already applied to `sql_analyze` and other tools. Co-Authored-By: Claude Opus 4.6 <[email protected]>
1 parent 244df89 commit 1e4c4e4

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

‎packages/opencode/src/altimate/tools/altimate-core-equivalence.ts‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,12 @@ export const AltimateCoreEquivalenceTool = Tool.define("altimate_core_equivalenc
2525
})
2626
const data = result.data as Record<string, any>
2727
const error = result.error ?? data.error ?? extractEquivalenceErrors(data)
28+
// "Not equivalent" is a valid analysis result, not a failure.
29+
// Only treat it as failure when there's an actual error.
30+
const isRealFailure = !!error
2831
return {
2932
title: `Equivalence: ${data.equivalent ? "EQUIVALENT" : "DIFFERENT"}`,
30-
metadata: { success: result.success, equivalent: data.equivalent, error },
33+
metadata: { success: !isRealFailure, equivalent: data.equivalent, ...(error && { error }) },
3134
output: formatEquivalence(data),
3235
}
3336
} catch (e) {

0 commit comments

Comments
 (0)