Repository navigation
Commit 12e47f5
committed
fix(workspace): address harness-bot round 8 — Event.Status + clear() on install fail
Two findings on packages/opencode/src/altimate/plugin/onboarding-telemetry.ts:
1. Subscribe to Event.Status with status.type === "idle" instead of the
deprecated Event.Idle. session/status.ts:49 marks Event.Idle as
`// deprecated`; the non-deprecated path is Event.Status filtered on the
idle status shape (matching what session/status.ts:176 uses for the
legacy Bus SSE mirror). Replaces the earlier NOTE that only asserted
"not the deprecated LegacyEvent" — the NOTE was technically correct but
deflected from the fact that Event.Idle itself is deprecated too.
(altimate-harness-bot #1099 comment 3837907427.)
2. Drain the pending set with pendingWorkspacePromptSessions.clear() on
install failure instead of iterating an install-time snapshot. A second
scan calling armWorkspacePromptOnSessionIdle after the snapshot but
before the install fails would otherwise leave its sessionID as a
permanent orphan in the pending set — no listener would ever fire for
it, so its post-scan workspace prompt would silently never arm.
(altimate-harness-bot #1099 comment 3837907105, P2.)1 parent 3427b2c commit 12e47f5
1 file changed
Lines changed: 19 additions & 22 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | 64 | | |
72 | 65 | | |
73 | 66 | | |
74 | 67 | | |
75 | 68 | | |
76 | 69 | | |
77 | | - | |
78 | | - | |
79 | | - | |
80 | | - | |
81 | | - | |
82 | | - | |
83 | | - | |
84 | | - | |
85 | | - | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
86 | 83 | | |
87 | 84 | | |
88 | 85 | | |
| |||
107 | 104 | | |
108 | 105 | | |
109 | 106 | | |
110 | | - | |
111 | | - | |
112 | | - | |
113 | | - | |
114 | | - | |
115 | | - | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
116 | 113 | | |
117 | 114 | | |
118 | 115 | | |
| |||
0 commit comments