Repository navigation
Commit 1296220
test: drop redundant 'sudo rm -rf' from router e2e cleanup (review)
The afterAll cleanups ran Bun.spawnSync(["sudo","rm","-rf",d]) before
rmSync(d, {recursive,force}). The temp dirs are mkdtemp dirs owned by the test
user, so rmSync alone cleans them; the sudo call is redundant, needs passwordless
sudo, and 'sudo rm -rf' is a dangerous pattern in a test. Removed (coderabbit).
The other e2e-review flags were false positives: each beforeAll already guards
with 'if (SKIP) return' (never throws when creds/image absent), and the ANSI
parse test does use real ESC bytes.
Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>1 parent bc44570 commit 1296220
2 files changed
Lines changed: 4 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
70 | | - | |
| 70 | + | |
| 71 | + | |
71 | 72 | | |
72 | 73 | | |
73 | 74 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | | - | |
| 41 | + | |
| 42 | + | |
42 | 43 | | |
43 | 44 | | |
44 | 45 | | |
| |||
0 commit comments