Repository navigation
Commit 128ea35
committed
fix(workspace): address consensus review on workspace memory
- **C1**: `MemoryStore.list`/`listAll` accept `opts.directory` so callers with
no ambient `Instance` — the `link` subcommand — can read project scope.
`read`/`blockPath` now thread that directory too; without it `list` scanned
the right directory but read every block back from the wrong one, so project
blocks silently vanished.
- **C2**: `hydrate` is idempotent per session id and no longer preceded by
`resetOverlay` on every user turn (`step === 1` runs per turn, not per
session), which made memory blink out of the prompt mid-fetch.
- **C3**: overlay and hydration state are keyed by session id, so concurrent
sessions in different workspaces cannot read each other's memory.
- **M1**: reads report `truncated`; writes are suppressed against a truncated
view rather than creating duplicates of records that were paged out.
- **M3**: `expires` is mirrored as `block_expires` and honoured on read, so a
TTL'd block cannot outlive its expiry on other machines.
- **M4**: backfill prefetches known records once instead of re-listing per block.
- **m1**: declined extractions are accounted separately from stored ones.
- `listAll` uses `Promise.allSettled`, so an unreadable project scope no longer
takes global memory down with it.
- Remote blocks no longer drive `incrementApplied`; the training-meta comment
regex is exported so the mirror's content hash cannot drift from the writer.
Tests: `store-directory.test.ts` exercises the real `MemoryStore` (the existing
`store.test.ts` re-implements its logic and so cannot catch path-resolution
bugs). Every invariant above was mutation-checked — each fails when its
guard is removed.1 parent 9dd716a commit 128ea35
13 files changed
Lines changed: 843 additions & 117 deletions
File tree
- packages/opencode
- src
- altimate
- training
- workspace
- memory
- session
- test
- altimate/workspace
- memory
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
5 | 11 | | |
6 | 12 | | |
7 | 13 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
62 | 65 | | |
63 | 66 | | |
64 | 67 | | |
| |||
73 | 76 | | |
74 | 77 | | |
75 | 78 | | |
76 | | - | |
| 79 | + | |
77 | 80 | | |
78 | | - | |
79 | | - | |
80 | | - | |
81 | | - | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
82 | 90 | | |
83 | | - | |
| 91 | + | |
84 | 92 | | |
85 | 93 | | |
86 | 94 | | |
| |||
92 | 100 | | |
93 | 101 | | |
94 | 102 | | |
| 103 | + | |
95 | 104 | | |
96 | 105 | | |
97 | 106 | | |
98 | | - | |
| 107 | + | |
99 | 108 | | |
100 | | - | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
101 | 115 | | |
102 | 116 | | |
103 | 117 | | |
104 | | - | |
| 118 | + | |
105 | 119 | | |
106 | | - | |
| 120 | + | |
107 | 121 | | |
108 | 122 | | |
109 | 123 | | |
110 | | - | |
| 124 | + | |
111 | 125 | | |
112 | 126 | | |
113 | 127 | | |
| |||
116 | 130 | | |
117 | 131 | | |
118 | 132 | | |
119 | | - | |
| 133 | + | |
120 | 134 | | |
121 | 135 | | |
122 | 136 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| 15 | + | |
15 | 16 | | |
16 | 17 | | |
17 | 18 | | |
| |||
22 | 23 | | |
23 | 24 | | |
24 | 25 | | |
25 | | - | |
| 26 | + | |
26 | 27 | | |
27 | 28 | | |
28 | | - | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
29 | 35 | | |
30 | | - | |
| 36 | + | |
31 | 37 | | |
32 | 38 | | |
33 | 39 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
141 | 141 | | |
142 | 142 | | |
143 | 143 | | |
144 | | - | |
145 | | - | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
146 | 151 | | |
147 | 152 | | |
148 | 153 | | |
| |||
0 commit comments