Skip to content

Commit 0bb8580

Browse files
fix: name the refreshed session on a precedence error row
Co-Authored-By: Claude Fable 5.1 <[email protected]> Claude-Session: https://claude.ai/code/session_011AhtJPr3nmT1Po92ZQk4VE
1 parent ab20e9c commit 0bb8580

3 files changed

Lines changed: 5 additions & 3 deletions

File tree

‎packages/opencode/src/altimate/workspace/engine-telemetry.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -185,12 +185,12 @@ export function resetEngineTelemetryForTests(): void {
185185
precedenceSeen.clear()
186186
}
187187

188-
export function trackEngineError(stage: EngineStage, message: string): void {
188+
export function trackEngineError(stage: EngineStage, message: string, sessionID?: string): void {
189189
try {
190190
Telemetry.track({
191191
type: "workspace_engine_error",
192192
timestamp: Date.now(),
193-
session_id: sessionId(),
193+
session_id: sessionID ?? sessionId(),
194194
stage,
195195
message: Telemetry.maskString(message).slice(0, 200),
196196
})

‎packages/opencode/src/altimate/workspace/precedence.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -533,7 +533,7 @@ export async function refresh(
533533
result = await derive(sessionID, tools)
534534
} catch (err) {
535535
log.warn("precedence could not be derived; running locally with a notice", { sessionID, err: String(err) })
536-
trackEngineError("precedence", String(err))
536+
trackEngineError("precedence", String(err), sessionID)
537537
result = EMPTY("derive-failed")
538538
}
539539
if (ruleset) result.ruleset = ruleset

‎packages/opencode/test/altimate/workspace/engine-telemetry.test.ts‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,8 @@ describe("workspace engine telemetry builders", () => {
137137
expect(err.stage).toBe("attach")
138138
expect(err.message.length).toBeLessThanOrEqual(200)
139139
expect(err.message).not.toContain("/home/someone")
140+
trackEngineError("precedence", "derive boom", "ses_p")
141+
expect(events.at(-1)).toEqual(expect.objectContaining({ stage: "precedence", session_id: "ses_p" }))
140142
trackRedirect("datamate", "status", 9)
141143
expect(events.at(-1)).toEqual(
142144
expect.objectContaining({

0 commit comments

Comments
 (0)