Skip to content

Commit 0a9c433

Browse files
suryaiyer95claude
andcommitted
fix: address major review findings in telemetry PII masking
- Extend `maskString` to also mask double-quoted strings (`"John"`, `$$secret$$`-adjacent) — single-quoted-only regex was flagged as PII leak - Keep `connection` in `ERROR_PATTERNS` keywords (broad but intentional) - Truncate `masked_sql` to 2000 chars before sending — was unbounded unlike `error_message` (500) and `masked_args` (2000) Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
1 parent ead7a20 commit 0a9c433

2 files changed

Lines changed: 6 additions & 3 deletions

File tree

‎packages/opencode/src/altimate/native/connections/register.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@ register("sql.execute", async (params: SqlExecuteParams): Promise<SqlExecuteResu
251251
warehouse_type: warehouseType,
252252
query_type: detectQueryType(params.sql),
253253
error_message: maskedErrorMsg,
254-
masked_sql: Telemetry.maskString(params.sql),
254+
masked_sql: Telemetry.maskString(params.sql).slice(0, 2000),
255255
duration_ms: Date.now() - startTime,
256256
})
257257
} catch {}

‎packages/opencode/src/altimate/telemetry/index.ts‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -451,9 +451,12 @@ export namespace Telemetry {
451451
)
452452
}
453453

454-
// Mirrors altimate-sdk mask_string: replace '...' → ?, collapse whitespace.
455454
export function maskString(s: string): string {
456-
return s.replace(/'(?:[^'\\]|\\.)*'/g, "?").replace(/\s+/g, " ").trim()
455+
return s
456+
.replace(/'(?:[^'\\]|\\.)*'/g, "?")
457+
.replace(/"(?:[^"\\]|\\.)*"/g, "?")
458+
.replace(/\s+/g, " ")
459+
.trim()
457460
}
458461

459462
function maskValue(value: unknown, key?: string): unknown {

0 commit comments

Comments
 (0)