Repository navigation
Commit 68aef83
fix(ghauth): persist device-flow token with --insecure-storage (#111)
## What
Add `--insecure-storage` to the in-container `gh auth login --web`
invocation.
## Why
`gh auth login --web` defaults to the system keyring. The sandbox has no
keyring/D-Bus, so a freshly built container (gh 2.93) fails **right
after the browser grant** — the token is never written, `~/.config/gh`
stays empty, and `mirabilis launch` dies with `GitHub sign-in — exit
status 1`. An older gh stored to a file by default, which is why sign-in
used to work before a rebuild.
`--insecure-storage` writes the token to a file in the persistent
`gh-config` volume — the storage this design already depends on (a
keyring token wouldn't survive a container rebuild anyway, and the
container *is* the security boundary per `SECURITY.md`).
## Verification
In the live locked-down container, piping a token through the
file-storage path logs in cleanly (`exit 0`, token in `hosts.yml`); the
keyring default is the only thing that breaks. `go build ./...`,
`gofmt`, `go vet`, and `go test ./internal/ghauth/...` are green.
Refs cli/cli#10108.
Co-authored-by: Aleksandr Shchuka <[email protected]>
Co-authored-by: Claude Fable 5 <[email protected]>1 parent 05c4c44 commit 68aef83
2 files changed
Lines changed: 12 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
84 | 84 | | |
85 | 85 | | |
86 | 86 | | |
87 | | - | |
| 87 | + | |
| 88 | + | |
88 | 89 | | |
89 | 90 | | |
90 | 91 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
73 | 73 | | |
74 | 74 | | |
75 | 75 | | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
76 | 86 | | |
77 | 87 | | |
78 | 88 | | |
| |||
0 commit comments