Skip to content

Commit 5dbae38

Browse files
committed
snapshots/testsuite: Rename: fix fuse-overlayfs incompatibility
Signed-off-by: Akihiro Suda <[email protected]>
1 parent f84b2b4 commit 5dbae38

1 file changed

Lines changed: 10 additions & 4 deletions

File tree

snapshots/testsuite/issues.go

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -128,10 +128,16 @@ func checkRename(ss string) func(ctx context.Context, t *testing.T, sn snapshots
128128
)
129129

130130
var applier []fstest.Applier
131-
if ss != "overlayfs" {
132-
// With neither OVERLAY_FS_REDIRECT_DIR nor redirect_dir,
133-
// renaming the directory on the lower directory doesn't work on overlayfs.
134-
// https://github.com/torvalds/linux/blob/v5.18/Documentation/filesystems/overlayfs.rst#renaming-directories
131+
switch ss {
132+
// With neither OVERLAY_FS_REDIRECT_DIR nor redirect_dir,
133+
// renaming the directory on the lower directory doesn't work on overlayfs.
134+
// https://github.com/torvalds/linux/blob/v5.18/Documentation/filesystems/overlayfs.rst#renaming-directories
135+
//
136+
// It doesn't work on fuse-overlayfs either.
137+
// https://github.com/containerd/fuse-overlayfs-snapshotter/pull/53#issuecomment-1543442048
138+
case "overlayfs", "fuse-overlayfs":
139+
// NOP
140+
default:
135141
applier = append(applier, fstest.Rename("/dir1", "/dir2"))
136142
}
137143
applier = append(

0 commit comments

Comments
 (0)