You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR improves the custom_sub_filter feature merged in #151 with the following changes:
Relocated Plugin Directory: Moved subs2srs_sub_filter from ~/.config/mpv/ to ~/.config/mpv/scripts/.
It now follows the standard mpv plugin structure (including a placeholder main.lua), making it easier to manage within the standard scripts environment.
Note: The logic remains in subs2srs_sub_filter.lua rather than main.lua because this is a specialized module dedicated to mpvacious rather than a standalone mpv script.
Extended Customization via init(): The subs2srs_sub_filter.lua now returns an init() function. This allows users to define their own logic, such as registering custom hotkeys.
Cleanup: Removed redundant or unnecessary configuration parameters to simplify the codebase.
Previously, all documentation lived in subs2srs.conf. Since that section was removed, the documentation is gone. To fix this, please add a section to README.md explaining how to use custom subtitle filters.
I initially chose custom_sub_filter for brevity, but I’ve realized that using the full word subtitle (e.g., custom_subtitle_filter) would be more explicit and sounds better. Since the feature isn't widely used yet, would it be okay to rename all these *_sub_filter things to *_subtitle_filter?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the custom_sub_filter feature merged in #151 with the following changes:
Relocated Plugin Directory: Moved
subs2srs_sub_filterfrom~/.config/mpv/to~/.config/mpv/scripts/.It now follows the standard mpv plugin structure (including a placeholder
main.lua), making it easier to manage within the standard scripts environment.Note: The logic remains in
subs2srs_sub_filter.luarather thanmain.luabecause this is a specialized module dedicated to mpvacious rather than a standalone mpv script.Extended Customization via init(): The
subs2srs_sub_filter.luanow returns aninit()function. This allows users to define their own logic, such as registering custom hotkeys.Cleanup: Removed redundant or unnecessary configuration parameters to simplify the codebase.