remove full-width spaces and duplicated spaces in subtitles#146
Merged
tatsumoto-ren merged 4 commits intoAug 29, 2025
Conversation
Comment on lines
+151
to
+159
| this.remove_full_width_spaces = function(str) | ||
| -- remove so-called Ideographic Spaces | ||
| return str:gsub(' +', ' ') | ||
| end | ||
|
|
||
| this.remove_duplicated_spaces = function(str) | ||
| return str:gsub(' +', ' ') | ||
| end | ||
|
|
Member
There was a problem hiding this comment.
You can merge these two patterns into one.
this.normalize_spaces = function(str)
-- replace sequences of ASCII spaces or full-width ideographic spaces with a single ASCII space
return str:gsub('[ ]+', ' ')
end
Member
|
Also, consider using the |
Contributor
Author
The nuke_spaces option is supposed to remove all spaces, which isn't what I want. Also, it doesn't affect full-width ideographic spaces. |
Member
I see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These spaces are anoying...