chore(deps): Support Python 3.13#3756
Conversation
|
If the tests are green, please try yourself @paul-gauthier 😄 |
13b2d6d to
94b10c8
Compare
|
FYI there were many llama-index-core releases since you pinned 0.12.26 3 weeks ago, maybe test_help will work again 🤞😅 |
| numpy>=2 | ||
|
|
||
| # Mac x86 only supports 2.2.2 | ||
| # Drop Mac x86 support |
There was a problem hiding this comment.
See also #3444 (comment) for an ongoing discussion about keeping or dropping Mac x86 support.
There was a problem hiding this comment.
Sure, but you can't fight time 😅 torch 2.7 just came out, they dropped Mac x86 support a year ago.
If it's any relief, Apple stopped selling Intel Macs 2 years ago and will probably stop supporting them in macOS 17 next year.
Maybe AI is more bleeding edge than other uses of computers, changing and developing faster?
There was a problem hiding this comment.
I think that this decision should be ultimately up to the project maintainer. /cc @paul-gauthier
There was a problem hiding this comment.
4989248 to
ac1dc82
Compare
|
@claui How is the review progressing? |
|
@reneleonhardt Sorry but I’m not actively reviewing this PR. The intent of my comment was to make sure you’re aware of the existing discussion. If GitHub shows me as a reviewer for this PR, then that’s misleading. Sorry about that. In fact, I’ve filed #3516 (motivated by the Intel Mac requirement) back in March, i.e. before you filed this competing PR. I’m still waiting on @paul-gauthier’s feedback on it. |
|
Yeah, it's always confusing to me that a contributor isn't allowed to request a review 😞 |
|
So... AI help for faster contributions isn't wanted and human help for dropping Python 3.9 isn't wanted either, now my work will never get reviewed 👍 |
|
@reneleonhardt Many thanks for this PR! I've been using your PR locally for several weeks, and it worked perfectly both in 3.12/3.13 envs – truly appreciate you sharing this. It looks like Python 3.13 support might be getting integrated by the maintainer more gradually, in separate parts – perhaps that's why this PR has some conflicts now. That's a challenging situation, and I can imagine it might be disheartening. Despite that, it really shows that any good contribution you share can make a real difference for someone – your work here has definitely made one for me. Hope this feedback is a positive note! |
ac1dc82 to
9829c21
Compare
|
Thank you for trying my PR, feels better than being ignored and eventually closed... |
|
@reneleonhardt, could you resolve conflicts in this branch? |
|
This good old pip-compile style dependency management nobody is using anymore for years is an absolute nightmare. Updates are literally time-sensitive, now every dependency constraint in every "requirement" file has to be reevaluated to satisfy all supported Python versions (supposedly 3.10, 3.11, 3.12 and maybe 3.13 if my work would've been merged). It would be much easier to throw all ancient requirement files away and support the packaging standard (groups in pyproject.toml): |
Closes #3037