Repository navigation
Commit 28cd2a2
fix: revert boolean field from Switch back to native checkbox
The PR had swapped the boolean <Input type="checkbox"> for a shadcn
<Switch>, which dropped the `required` attribute (Switch had none) and
added a capitalized "True"/"False" label. Revert to the native checkbox
that the Inspector used previously: it natively supports `required`
(restoring parity with every other field) and removes the label, so the
control is consistent with the rest of the form again.
Reverts the boolean test assertions from role="switch"/aria-checked back
to role="checkbox" in both component test files.
Addresses review items modelcontextprotocol#3 (required dropped) and modelcontextprotocol#5 (True/False label)
on modelcontextprotocol#1258 by removing the Switch change that introduced them.
Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>1 parent df40cf6 commit 28cd2a2
3 files changed
Lines changed: 23 additions & 28 deletions
File tree
- client/src/components
- __tests__
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
13 | 12 | | |
14 | 13 | | |
15 | 14 | | |
| |||
571 | 570 | | |
572 | 571 | | |
573 | 572 | | |
574 | | - | |
| 573 | + | |
575 | 574 | | |
576 | | - | |
| 575 | + | |
577 | 576 | | |
578 | 577 | | |
579 | 578 | | |
580 | | - | |
581 | | - | |
582 | | - | |
583 | | - | |
584 | | - | |
585 | | - | |
586 | | - | |
587 | | - | |
588 | | - | |
589 | | - | |
590 | | - | |
| 579 | + | |
| 580 | + | |
| 581 | + | |
| 582 | + | |
| 583 | + | |
| 584 | + | |
| 585 | + | |
591 | 586 | | |
592 | 587 | | |
593 | 588 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
205 | 205 | | |
206 | 206 | | |
207 | 207 | | |
208 | | - | |
209 | | - | |
210 | | - | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
211 | 211 | | |
212 | 212 | | |
213 | 213 | | |
| |||
332 | 332 | | |
333 | 333 | | |
334 | 334 | | |
335 | | - | |
336 | | - | |
337 | | - | |
338 | | - | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
339 | 339 | | |
340 | 340 | | |
341 | 341 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
434 | 434 | | |
435 | 435 | | |
436 | 436 | | |
437 | | - | |
| 437 | + | |
438 | 438 | | |
439 | 439 | | |
440 | 440 | | |
| |||
443 | 443 | | |
444 | 444 | | |
445 | 445 | | |
446 | | - | |
447 | | - | |
| 446 | + | |
| 447 | + | |
448 | 448 | | |
449 | 449 | | |
450 | 450 | | |
| |||
457 | 457 | | |
458 | 458 | | |
459 | 459 | | |
460 | | - | |
461 | | - | |
| 460 | + | |
| 461 | + | |
462 | 462 | | |
463 | 463 | | |
464 | 464 | | |
| |||
472 | 472 | | |
473 | 473 | | |
474 | 474 | | |
475 | | - | |
476 | | - | |
| 475 | + | |
| 476 | + | |
477 | 477 | | |
478 | 478 | | |
479 | 479 | | |
| |||
0 commit comments