Repository navigation
fix(drift): recognize none as a noindex directive - #404
Merged
AgriciDaniel merged 1 commit intoNov 10, 2026
Merged
Conversation
myforkiq Bot
pushed a commit
to bguisad/claude-seo
that referenced
this pull request
Nov 10, 2026
… BOM handling Follow-ups to AgriciDaniel#332, AgriciDaniel#385, AgriciDaniel#345, AgriciDaniel#384 and AgriciDaniel#404: - one malformed URL in an image or link no longer aborts the parse; bad values are listed under malformed_urls - the image probe reports a malformed src or a non-image response as unverified and no longer labels arbitrary XML as SVG - <base href> is honoured for http and https only; fragment-only links follow a base that points elsewhere (raised by agammann on AgriciDaniel#385) - <br> in headings and link text reads as a space - a plain-text sitemap that starts with a UTF-8 BOM is valid - drift reads semicolon-separated robots directives Co-Authored-By: Claude Fable 5.2 <[email protected]>
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The noindex drift rule only searches for the substring
noindex. It therefore misses a newly addednonedirective, and reports a false new restriction when an existingnoneis replaced withnoindex. Google documentsnoneas equivalent tonoindex, nofollow: https://developers.google.com/search/docs/crawling-indexing/robots-meta-tag#noneCompare complete, case-insensitive directives and treat
noneandnoindexas equivalent indexing restrictions. Parameterized values such asmax-image-preview:noneandmax-image-preview: nonedo not become indexing restrictions. Independent directives still work with comma or whitespace separation. Regression cases also check that a previous parameter value cannot hide a newly addednone.Validation
python -m pytest -q tests/test_drift_robots_directives.py tests/test_drift_portability.py: 17 passed.ruff check scripts/drift_compare.py tests/test_drift_robots_directives.py: passed.git diff --check: passed.Tests cover the rule directly without network access.