refactor: use guard getters#8339
Merged
Merged
Conversation
Member
Author
|
See #8340 |
erights
force-pushed
the
markm-use-guard-getters
branch
from
September 16, 2023 09:19
ec34450 to
111c33a
Compare
erights
commented
Sep 16, 2023
| M.remotable('instanceAdmin'), | ||
| ).returns(M.promise()), | ||
| deleteInstanceAdmin: M.call(InstanceAdminI).returns(), | ||
| deleteInstanceAdmin: M.call(InstanceAdminShape).returns(), |
Member
Author
There was a problem hiding this comment.
This bug was only caught by seeing #8340 fail , because it uses the stricter endojs/endo#1712
michaelfig
approved these changes
Sep 16, 2023
michaelfig
left a comment
michaelfig
left a comment
Member
There was a problem hiding this comment.
LGTM! I'd love to see this land in the SDK.
erights
added
automerge:rebase
michaelfig
reviewed
Sep 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To pave the way for endojs/endo#1712 , switch from directly accessing the fields of guards to using the guard type's validating payload getter, and then accessing the fields of the payload.
See also endojs/endo#1771, which would enable us to remove the two
@ts-expect-errors that we had to add.