Repository navigation
fix(sdk-ts): scope polling pause time to each wait - #1163
santoshkumarradha merged 1 commit into
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Performance
✓ No regressions detected |
📊 Coverage gateThresholds from
✅ Gate passedNo surface regressed past the allowed threshold and the aggregate stayed above the floor. |
📐 Patch coverage gateThreshold: 80% on lines this PR touches vs
✅ Patch gate passedEvery surface whose lines were touched by this PR has patch coverage at or above the threshold. |
santoshkumarradha
left a comment
There was a problem hiding this comment.
Reviewed the implementation and its focused tests. The change is scoped, the CLA and required checks are green, and I found no blocking issue.
Summary
Reusing a parent
PauseClockcurrently extends a newwaitForExecutionResulttimeout by all time the execution previously spent paused. For example, an earlier 4-second pause turns the next 200 ms polling budget into roughly 4.2 seconds.Snapshot the cumulative paused time when each wait starts, then subtract only additional paused time. The shared execution clock, WAITING transitions, and status callbacks retain their existing behavior.
Type of change
Test plan
./scripts/test-all.sh— control plane and Go SDK passed; Python SDK: 2,959 passed, 4 skipped, 38 deselected; TypeScript SDK: 1,392 passed, 1 skipped; Web UI: 837 passed.make fmt tidy— passed; unrelated formatting output from the existing baseline was reverted.cd sdk/typescript && npm run lint— passed.Go checks ran in the existing isolated Linux Go 1.25.14 environment with an offline public-DNS fixture; Python and Node checks ran locally. The suite's default exclusions were retained. The two past-pause cases fail on the original implementation and pass with this fix.
Test coverage
CI coverage and hosted CLA checks remain to be evaluated after PR creation.
Checklist
docs/CONTRIBUTING.mdanddocs/DEVELOPMENT.md.