Repository navigation
fix(python-sdk): preserve boolean defaults in agent CLI calls - #1151
santoshkumarradha merged 1 commit into
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Performance
✓ No regressions detected |
📊 Coverage gateThresholds from
✅ Gate passedNo surface regressed past the allowed threshold and the aggregate stayed above the floor. |
📐 Patch coverage gateThreshold: 80% on lines this PR touches vs
✅ Patch gate passedEvery surface whose lines were touched by this PR has patch coverage at or above the threshold. |
santoshkumarradha
left a comment
There was a problem hiding this comment.
Reviewed the argparse default handling and its regression coverage. The focused CLI tests, CLA, and required checks are green.
Summary
When
python main.py callomits a boolean option, it passesFalseto the skill or reasoner even if the function declares a default ofTrue. Use the function's declared default when the option is omitted. A supplied flag still enables the option, and a boolean parameter without a declared default still falls back toFalse.Type of change
Test plan
./scripts/test-all.sh. The Go control plane and Go SDK passed. Python SDK reported 2,950 passed, TypeScript SDK core reported 1,383 passed, and Web UI reported 837 passed.make fmt tidy, Python SDK Ruff and mypy, memory-event tests with websockets 12.0 and 15.0.1 (28 passed each), and the Python performance benchmark.Test coverage
Checklist
docs/CONTRIBUTING.mdanddocs/DEVELOPMENT.md.