Repository navigation
fix(python): retain memory event filters across reconnects - #1145
santoshkumarradha merged 1 commit into
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Performance
✓ No regressions detected |
📊 Coverage gateThresholds from
✅ Gate passedNo surface regressed past the allowed threshold and the aggregate stayed above the floor. |
📐 Patch coverage gateThreshold: 80% on lines this PR touches vs
✅ Patch gate passedEvery surface whose lines were touched by this PR has patch coverage at or above the threshold. |
santoshkumarradha
left a comment
There was a problem hiding this comment.
Reviewed the filter persistence change and its reconnect coverage, including encoded parameters and initial failures. Focused memory-event tests pass locally.
|
This is approved on its own merits. The protected merge queue currently marks it unmergeable because it overlaps #1142, which is ahead of it in the queue and changes the same memory-events lifecycle code. Please rebase it on current main after #1142 lands, then the checks can rerun with both fixes together. |
cc96c4c to
0bc3ff6
Compare
santoshkumarradha
left a comment
There was a problem hiding this comment.
Rebased diff is focused on preserving explicit memory-event filters through reconnects. The reconnect, failed-connect, copied-parameter, and unfiltered paths are covered; focused tests pass locally, and CLA plus required checks are green.
Summary
MemoryEventClientstopped sendingpatterns,scope, andscope_idafter a dropped connection or an initial failure followed bysubscribe(). Snapshot the explicit connection parameters and reuse them for background connections, while preserving explicitconnect()defaults.Rebased onto current
mainafter #1142 landed. Subscription-initiated connections retain the filters and use the shutdown fix's tracked background tasks, so closing the client can cancel them. Both sets of memory-event regressions pass together.Prepared with AI assistance, independently reviewed and tested.
Type of change
Test plan
./scripts/test-all.sh(control plane, Go SDK, Python SDK with unchanged default coverage/markers, TypeScript SDK, and web UI). Go uses an isolated Linux Go 1.25.14 runtime with controlled public/invalid DNS; Python 3.12 and JavaScript run natively on macOS..github/workflows/memory-metrics.yml.make fmt tidycompleted. Unrelated baseline formatter changes were restored; the two PR files already match the formatter and module files were unchanged.Test coverage
Checklist
docs/CONTRIBUTING.mdanddocs/DEVELOPMENT.md.Related issues / PRs
Source-discovered Python bug, separate from the TypeScript filter feature in #838. This branch now includes the Python shutdown fix merged in #1142.