Repository navigation
fix: detect Java 25 and newer Minecraft requirements - #50
Merged
wayback09 merged 1 commit intoNov 8, 2026
Merged
Conversation
The Java settings page only checked 8, 17, and 21, so a managed Java 25 runtime was invisible. Build the list from installed managed runtimes and each instance's version.json instead. Also teach the version fallback about year-based Minecraft versions (26.1+ -> Java 25) and fix 1.21 without a patch suffix mapping to Java 17.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Java settings page only listed Java 8, 17, and 21. A managed Java 25 runtime downloaded by the launcher was invisible, and the version fallback did not understand year-based Minecraft versions such as 26.3.
Changes
GetJavaStatusnow builds its version list from:<data>/runtimes/java-*version.jsonjavaVersion.majorVersionjava.ManagedJavaVersions().RequiredJavaVersionnow maps year-based versions 26.1+ to Java 25, and fixes1.21(no patch suffix) mapping to Java 17 instead of Java 21.Verification
go test ./...npm run check— 0 errorsnpm run buildManagedJavaVersions()returns[8 17 21 25].Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.