Skip to content

fix: detect Java 25 and newer Minecraft requirements - #50

Merged
wayback09 merged 1 commit into
Aether-Launcher:mainfrom
DarkLabsStudio:fix/java-25-detection
Nov 8, 2026
Merged

wayback09 merged 1 commit into
Aether-Launcher:mainfrom
DarkLabsStudio:fix/java-25-detection

Conversation

@DarkLabsStudio

@DarkLabsStudio DarkLabsStudio commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Problem

The Java settings page only listed Java 8, 17, and 21. A managed Java 25 runtime downloaded by the launcher was invisible, and the version fallback did not understand year-based Minecraft versions such as 26.3.

Changes

  • GetJavaStatus now builds its version list from:
    • the base majors 8, 17, and 21
    • every managed runtime under <data>/runtimes/java-*
    • every installed instance's version.json javaVersion.majorVersion
  • Add java.ManagedJavaVersions().
  • RequiredJavaVersion now maps year-based versions 26.1+ to Java 25, and fixes 1.21 (no patch suffix) mapping to Java 17 instead of Java 21.
  • Server process Java selection now uses the shared mapping.
  • Settings labels show Java 21 for 1.20.5–1.21.x and Java 25 for 26.1+.

Verification

  • go test ./...
  • npm run check — 0 errors
  • npm run build
  • Confirmed locally that ManagedJavaVersions() returns [8 17 21 25].

Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

The Java settings page only checked 8, 17, and 21, so a managed Java 25 runtime was invisible. Build the list from installed managed runtimes and each instance's version.json instead.

Also teach the version fallback about year-based Minecraft versions (26.1+ -> Java 25) and fix 1.21 without a patch suffix mapping to Java 17.
@wayback09
wayback09 merged commit 3da9b48 into Aether-Launcher:main Nov 8, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants