Skip to content

fix: keep install state across Home navigation - #49

Merged
wayback09 merged 1 commit into
Aether-Launcher:mainfrom
DarkLabsStudio:fix/install-remount-error
Nov 8, 2026
Merged

wayback09 merged 1 commit into
Aether-Launcher:mainfrom
DarkLabsStudio:fix/install-remount-error

Conversation

@DarkLabsStudio

@DarkLabsStudio DarkLabsStudio commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Problem

While an instance is installing, leaving Home for Settings and returning shows:

Error: installation already in progress for <id>

even though the original install keeps running and finishes. Home is remounted with the same activeInstanceId, so loadAndInstall calls InstallInstance again. The backend correctly refuses the second pipeline, but the UI renders that refusal as a failure.

Changes

  • Move install progress/error state from Home.svelte into a global installStore so it survives navigation.
  • Guard handleInstall and the auto-install path so a remount or double click reuses the running pipeline.
  • Keep real failures visible; only auto-start when the install state is idle.
  • Make InstallInstance idempotent: if the per-instance claim is already held, log and return nil instead of returning an error.

Verification

  • npm run check — 0 errors
  • npm run build
  • go test ./...
  • git diff --check

Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

Install progress and errors were page-local, so leaving Home and coming back reset the UI and triggered a second InstallInstance call. The backend returned 'installation already in progress', which surfaced as a false error while the original pipeline kept running.

Move install state into a global store, guard duplicate starts, and make InstallInstance idempotent for an already-running pipeline.
@wayback09
wayback09 merged commit 619cd5d into Aether-Launcher:main Nov 8, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants