Fix kmscon not restarting the login shell#96
Merged
Aetf merged 1 commit intoAetf:developfrom Jan 9, 2025
Merged
Conversation
Sometime the SIGCHLD handler is not called, but kmscon still receives a HUP on the pty file descriptor. In this case, reap the child, and spawn another login process, to avoid hanging for ever on a defunct child. Signed-off-by: Jocelyn Falempe <[email protected]>
Aetf
approved these changes
Jan 9, 2025
Mop-u
added a commit
to Mop-u/dotfiles
that referenced
this pull request
Jan 10, 2025
The reason for that is that SIGCHLD is not blocked before pango creates its own glib thread. I made a RFC fix here: #106 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometime the SIGCHLD handler is not called, but kmscon still receives a HUP on the pty file descriptor. In this case, reap the child, and spawn another login process, to avoid hanging for ever on a defunct child.
Fix #82
Fix #80