Allow quoting to preserve spaces in the login option in config file#59
Merged
Aetf merged 2 commits intoAetf:developfrom Aug 5, 2022
Merged
Allow quoting to preserve spaces in the login option in config file#59Aetf merged 2 commits intoAetf:developfrom
Aetf merged 2 commits intoAetf:developfrom
Conversation
viccie30
commented
Jul 23, 2022
viccie30
commented
Jul 23, 2022
This allows running unit tests on newly added/changed/fixed code in libshl. Remove the older tests from meson's test framework, because they require human interaction. They are still built.
There are three ways to quote supported, derived from shell quoting. - Without surrounding quotes, backspace unconditionally escapes the following character. `\ ` is parsed as a single space which does not separate words. - Within double quotes, backspace only escapes backspace and double quotes. `"\\"` is parsed as a single backslash, while `"\b"` is parsed as the two characters backslash and 'b'. All white space is preserved within quotes. - Within single quotes, backspace does not work as an escape character. `'\"'` is parsed as the two characters backslash and dobule quote. All white space is preserved within quotes. Fixes Aetf#57
viccie30
force-pushed
the
split_command_string
branch
from
76cd02a to
51e41dd
Compare
Aetf
approved these changes
Aug 5, 2022
Owner
Aetf
left a comment
Aetf
left a comment
There was a problem hiding this comment.
Thanks!! LGTM. The next step would be to setup CI to run on every commit but that's a separate issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are three ways to quote supported, derived from shell quoting.
following character.
\is parsed as a single space which does notseparate words.
quotes.
"\\"is parsed as a single backslash, while"\b"is parsedas the two characters backslash and 'b'. All white space is preserved
within quotes.
'\"'is parsed as the two characters backslash and dobule quote.All white space is preserved within quotes.
Fixes #57