Conversation
this eval is harmful as it makes it necessary to add one more level of escaping to the arguments. Note this could break existing users, but given the script is recent I believe it is still worth improving. If eval-like behaviour is required one can run `sh -c ...` for identical effect: ``` $ cat /tmp/t.sh #!/bin/sh echo --- no eval "$@" echo --- eval eval "$@" echo --------------- $ /tmp/t.sh printf "%s\n" "test space" --- no eval test space --- eval testnspacen--------------- $ /tmp/t.sh sh -c 'printf "%s\n" "test space"' --- no eval test space --- eval printf: usage: printf [-v var] format [arguments] --------------- ``` Fixes: 4c2893a ("Add drmSetBackground and drmSetForeground escape codes") Signed-off-by: Dominique Martinet <[email protected]>
Collaborator
|
Good catch, thanks for your PR, the eval is not necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this eval is harmful as it makes it necessary to add one more level of escaping to the arguments.
Note this could break existing users, but given the script is recent I believe it is still worth improving.
If eval-like behaviour is required one can run
sh -c ...for identical effect:Fixes: 4c2893a ("Add drmSetBackground and drmSetForeground escape codes")
(for simple commands like just running a session wrapper even with simple arguments this doesn't change anything, it would only break for an user using spaces or quotes)