Fix character overflow with JetBrainsMono Nerd Font Mono#146
Merged
Conversation
There are some glitches around detection of characters that can overflow: - A rounding error in pango_layout_line_get_pixel_extents() - Some characters have an offset, that was not taken into account for the overflow detection. Fixes 5c2e2b3 Double width overflow support Fixes Aetf#145 Signed-off-by: Jocelyn Falempe <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some glitches around detection of characters that can overflow:
Fixes 5c2e2b3 Double width overflow support
Fixes #145